From: Jonathan Wakely <jwakely@redhat.com>
To: NightStrike <nightstrike@gmail.com>
Cc: Nicholas Krause <xerofoify@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Use proper print formatter in main function in fixincl.c
Date: Mon, 07 Jan 2019 16:04:00 -0000 [thread overview]
Message-ID: <20190107160423.GU15627@redhat.com> (raw)
In-Reply-To: <CAF1jjLt5UsF6wvK6nZSoQO-ww8ENCFzt+BbQBbWoKbi9HLbm3A@mail.gmail.com>
On 07/01/19 11:01 -0500, NightStrike wrote:
>On Mon, Jan 7, 2019 at 10:57 AM Jonathan Wakely <jwakely@redhat.com> wrote:
>>
>> On 20/12/18 17:23 -0500, Nicholas Krause wrote:
>> >This fixes the bug id, 71176 to use the proper known
>> >code print formatter type, %lu for size_t rather than
>> >%d which is considered best pratice for print statements.
>>
>> Well the proper specifier for size_t is %zu, but since you cast to
>> unsigned long then %lu is right.
>
>Wouldn't the right fix be to not cast to unsigned long and use %zu?
That was added in C99 and so is not part of C++98. GCC only requires a
C++98 compiler (and library).
next prev parent reply other threads:[~2019-01-07 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 22:27 Nicholas Krause
2019-01-07 15:57 ` Jonathan Wakely
2019-01-07 16:02 ` NightStrike
2019-01-07 16:04 ` Jonathan Wakely [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-20 2:49 Nicholas Krause
2018-12-20 21:07 ` Joseph Myers
2018-12-20 22:19 ` nick
2018-12-19 23:35 Nicholas Krause
2018-12-20 0:20 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107160423.GU15627@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nightstrike@gmail.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).