From: James Greenhalgh <james.greenhalgh@arm.com>
To: Sam Tebbs <Sam.Tebbs@arm.com>
Cc: Sudakshina Das <Sudi.Das@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH 2/3][GCC][AARCH64] Add new -mbranch-protection option to combine pointer signing and BTI
Date: Mon, 07 Jan 2019 18:11:00 -0000 [thread overview]
Message-ID: <20190107181124.GA4896@arm.com> (raw)
In-Reply-To: <afc14510-028d-afc4-6325-eeac6a83f618@arm.com>
On Thu, Dec 20, 2018 at 10:38:42AM -0600, Sam Tebbs wrote:
> On 11/22/18 4:54 PM, Sam Tebbs wrote:
<snip>
>
> Hi all,
>
> Attached is an updated patch with branch_protec_type renamed to
> branch_protect_type, some unneeded ATTRIBUTE_USED removed and an added
> use of ARRAY_SIZE.
>
> Below is the updated changelog.
>
> OK for trunk? I have committed the preceding patch in the series.
OK. Please get this in soon as we really want to be closing down for Stage 4
(and fix a few bugs in return :-) ).
Thanks,
James
>
> gcc/ChangeLog:
>
> 2018-12-20 Sam Tebbs<sam.tebbs@arm.com>
>
> * config/aarch64/aarch64.c (BRANCH_PROTECT_STR_MAX,
> aarch64_parse_branch_protection,
> struct aarch64_branch_protect_type,
> aarch64_handle_no_branch_protection,
> aarch64_handle_standard_branch_protection,
> aarch64_validate_mbranch_protection,
> aarch64_handle_pac_ret_protection,
> aarch64_handle_attr_branch_protection,
> accepted_branch_protection_string,
> aarch64_pac_ret_subtypes,
> aarch64_branch_protect_types,
> aarch64_handle_pac_ret_leaf): Define.
> (aarch64_override_options_after_change_1): Add check for
> accepted_branch_protection_string.
> (aarch64_override_options): Add check for
> accepted_branch_protection_string.
> (aarch64_option_save): Save accepted_branch_protection_string.
> (aarch64_option_restore): Save
> accepted_branch_protection_string.
> * config/aarch64/aarch64.c (aarch64_attributes): Add branch-protection.
> * config/aarch64/aarch64.opt: Add mbranch-protection. Deprecate
> msign-return-address.
> * doc/invoke.texi: Add mbranch-protection.
>
> gcc/testsuite/ChangeLog:
>
> 2018-12-20 Sam Tebbs<sam.tebbs@arm.com>
>
> * (gcc.target/aarch64/return_address_sign_1.c,
> gcc.target/aarch64/return_address_sign_2.c,
> gcc.target/aarch64/return_address_sign_3.c (__attribute__)): Change
> option to -mbranch-protection.
> * gcc.target/aarch64/(branch-protection-option.c,
> branch-protection-option-2.c, branch-protection-attr.c,
> branch-protection-attr-2.c): New file.
>
next prev parent reply other threads:[~2019-01-07 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 17:31 Sam Tebbs
2018-11-09 11:05 ` Sam Tebbs
2018-11-12 18:24 ` Sudakshina Das
2018-11-22 16:54 ` Sam Tebbs
2018-12-20 16:41 ` Sam Tebbs
2019-01-04 16:55 ` Sam Tebbs
2019-01-07 18:11 ` James Greenhalgh [this message]
2019-01-08 10:32 ` Sam Tebbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107181124.GA4896@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Sam.Tebbs@arm.com \
--cc=Sudi.Das@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).