From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86301 invoked by alias); 7 Jan 2019 18:11:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 86286 invoked by uid 89); 7 Jan 2019 18:11:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Change X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Jan 2019 18:11:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2346880D; Mon, 7 Jan 2019 10:11:32 -0800 (PST) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E100C3F5A0; Mon, 7 Jan 2019 10:11:30 -0800 (PST) Date: Mon, 07 Jan 2019 18:11:00 -0000 From: James Greenhalgh To: Sam Tebbs Cc: Sudakshina Das , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Marcus Shawcroft , nd Subject: Re: [PATCH 2/3][GCC][AARCH64] Add new -mbranch-protection option to combine pointer signing and BTI Message-ID: <20190107181124.GA4896@arm.com> References: <67f1be3b-0010-880e-4c81-a3781851b94b@arm.com> <6a0accfc-8def-baca-9fe8-da357b0e15bf@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00329.txt.bz2 On Thu, Dec 20, 2018 at 10:38:42AM -0600, Sam Tebbs wrote: > On 11/22/18 4:54 PM, Sam Tebbs wrote: > > Hi all, > > Attached is an updated patch with branch_protec_type renamed to > branch_protect_type, some unneeded ATTRIBUTE_USED removed and an added > use of ARRAY_SIZE. > > Below is the updated changelog. > > OK for trunk? I have committed the preceding patch in the series. OK. Please get this in soon as we really want to be closing down for Stage 4 (and fix a few bugs in return :-) ). Thanks, James > > gcc/ChangeLog: > > 2018-12-20 Sam Tebbs > > * config/aarch64/aarch64.c (BRANCH_PROTECT_STR_MAX, > aarch64_parse_branch_protection, > struct aarch64_branch_protect_type, > aarch64_handle_no_branch_protection, > aarch64_handle_standard_branch_protection, > aarch64_validate_mbranch_protection, > aarch64_handle_pac_ret_protection, > aarch64_handle_attr_branch_protection, > accepted_branch_protection_string, > aarch64_pac_ret_subtypes, > aarch64_branch_protect_types, > aarch64_handle_pac_ret_leaf): Define. > (aarch64_override_options_after_change_1): Add check for > accepted_branch_protection_string. > (aarch64_override_options): Add check for > accepted_branch_protection_string. > (aarch64_option_save): Save accepted_branch_protection_string. > (aarch64_option_restore): Save > accepted_branch_protection_string. > * config/aarch64/aarch64.c (aarch64_attributes): Add branch-protection. > * config/aarch64/aarch64.opt: Add mbranch-protection. Deprecate > msign-return-address. > * doc/invoke.texi: Add mbranch-protection. > > gcc/testsuite/ChangeLog: > > 2018-12-20 Sam Tebbs > > * (gcc.target/aarch64/return_address_sign_1.c, > gcc.target/aarch64/return_address_sign_2.c, > gcc.target/aarch64/return_address_sign_3.c (__attribute__)): Change > option to -mbranch-protection. > * gcc.target/aarch64/(branch-protection-option.c, > branch-protection-option-2.c, branch-protection-attr.c, > branch-protection-attr-2.c): New file. >