From: Marek Polacek <polacek@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: Re: C++ PATCH for c++/88830 - ICE with abstract class
Date: Mon, 14 Jan 2019 15:41:00 -0000 [thread overview]
Message-ID: <20190114154151.GD19569@redhat.com> (raw)
In-Reply-To: <20190114111014.GC30353@tucnak>
On Mon, Jan 14, 2019 at 12:10:14PM +0100, Jakub Jelinek wrote:
> On Sun, Jan 13, 2019 at 09:07:00PM -0500, Marek Polacek wrote:
> > diff --git gcc/cp/decl2.c gcc/cp/decl2.c
> > index e4cf4e0a361..7b656712471 100644
> > --- gcc/cp/decl2.c
> > +++ gcc/cp/decl2.c
> > @@ -2229,7 +2229,8 @@ maybe_emit_vtables (tree ctype)
> > never get generated. */
> > if (CLASSTYPE_PURE_VIRTUALS (ctype)
> > && TYPE_HAS_NONTRIVIAL_DESTRUCTOR (ctype)
> > - && DECL_DEFAULTED_IN_CLASS_P(CLASSTYPE_DESTRUCTOR(ctype)))
> > + && !CLASSTYPE_LAZY_DESTRUCTOR (ctype)
> > + && DECL_DEFAULTED_IN_CLASS_P (CLASSTYPE_DESTRUCTOR (ctype)))
> > note_vague_linkage_fn (CLASSTYPE_DESTRUCTOR(ctype));
>
> Just a formatting nit. s/CLASSTYPE_DESTRUCTOR/& / on the above line too
> when you are at it. Otherwise I came up with identical patch to yours
> (should have noticed the PR is ASSIGNED :( ).
:( I missed the second formatting problem, fixed here:
2019-01-14 Marek Polacek <polacek@redhat.com>
PR c++/88830 - ICE with abstract class.
* decl2.c (maybe_emit_vtables): Check CLASSTYPE_LAZY_DESTRUCTOR.
Fix formatting.
* g++.dg/other/abstract7.C: New test.
diff --git gcc/cp/decl2.c gcc/cp/decl2.c
index e4cf4e0a361..902bb8cab4f 100644
--- gcc/cp/decl2.c
+++ gcc/cp/decl2.c
@@ -2229,8 +2229,9 @@ maybe_emit_vtables (tree ctype)
never get generated. */
if (CLASSTYPE_PURE_VIRTUALS (ctype)
&& TYPE_HAS_NONTRIVIAL_DESTRUCTOR (ctype)
- && DECL_DEFAULTED_IN_CLASS_P(CLASSTYPE_DESTRUCTOR(ctype)))
- note_vague_linkage_fn (CLASSTYPE_DESTRUCTOR(ctype));
+ && !CLASSTYPE_LAZY_DESTRUCTOR (ctype)
+ && DECL_DEFAULTED_IN_CLASS_P (CLASSTYPE_DESTRUCTOR (ctype)))
+ note_vague_linkage_fn (CLASSTYPE_DESTRUCTOR (ctype));
/* Since we're writing out the vtable here, also write the debug
info. */
diff --git gcc/testsuite/g++.dg/other/abstract7.C gcc/testsuite/g++.dg/other/abstract7.C
new file mode 100644
index 00000000000..95781602c95
--- /dev/null
+++ gcc/testsuite/g++.dg/other/abstract7.C
@@ -0,0 +1,14 @@
+// PR c++/88830
+
+struct a {
+ ~a();
+};
+class b {
+ virtual void c(int &);
+};
+class C : b {
+ void c(int &);
+ virtual int d() = 0;
+ a e;
+};
+void C::c(int &) {}
next prev parent reply other threads:[~2019-01-14 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 2:07 Marek Polacek
2019-01-14 11:10 ` Jakub Jelinek
2019-01-14 15:41 ` Marek Polacek [this message]
2019-01-14 20:05 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114154151.GD19569@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).