From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: "Martin Liška" <mliska@suse.cz>,
"GCC Patches" <gcc-patches@gcc.gnu.org>,
"Jan Hubicka" <hubicka@ucw.cz>
Subject: Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).
Date: Wed, 16 Jan 2019 11:59:00 -0000 [thread overview]
Message-ID: <20190116115911.GR30353@tucnak> (raw)
In-Reply-To: <CAFiYyc0u-NQ2WGGukzxiVizwL7YtrT_+5Y_J80CrfWZUZ5On6w@mail.gmail.com>
On Wed, Jan 16, 2019 at 12:50:23PM +0100, Richard Biener wrote:
> I guess so. There's not much we can do about this other than making
> DECL_MODE dynamic the same way as TYPE_MODE. I still believe
> this is the wrong direction and instead RTL expansion should properly
> adjust DECL_RTL and generally on GIMPLE we shouldn't need to
> commit to modes early at all...
Are there cases where DECL_MODE (decl) should not be equal to
TYPE_MODE (TREE_TYPE (decl))? Is that for structs with flexible array
members where the initializer is filling up the flexible array member, or
something different?
E.g. in expand_debug* it shouldn't be hard to use TYPE_MODE if
VECTOR_TYPE_P (TREE_TYPE (decl)), but there are many other uses of
DECL_MODE.
Jakub
next prev parent reply other threads:[~2019-01-16 11:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 9:20 Martin Liška
2019-01-16 9:26 ` Martin Liška
2019-01-16 11:50 ` Richard Biener
2019-01-16 11:59 ` Jakub Jelinek [this message]
2019-01-16 12:01 ` Richard Biener
2019-01-16 12:06 ` Richard Biener
2019-01-17 11:21 ` Martin Liška
2019-01-17 12:51 ` Richard Biener
2019-01-18 14:25 ` H.J. Lu
2019-01-18 14:30 ` H.J. Lu
2019-04-15 6:50 ` Martin Liška
2019-04-15 7:50 ` Richard Biener
2019-04-15 8:11 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116115911.GR30353@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mliska@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).