From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51848 invoked by alias); 17 Jan 2019 07:59:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 51839 invoked by uid 89); 17 Jan 2019 07:59:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:716, H*Ad:U*ebotcazou X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Jan 2019 07:59:29 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 4815D81369; Thu, 17 Jan 2019 08:59:27 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8HJia1e5lEvG; Thu, 17 Jan 2019 08:59:27 +0100 (CET) Received: from chelles.act-europe.fr (chelles.act-europe.fr [IPv6:2a02:2ab8:224:1:d6be:d9ff:fef8:4565]) by smtp.eu.adacore.com (Postfix) with ESMTP id E1C42812E6; Thu, 17 Jan 2019 08:59:26 +0100 (CET) Received: by chelles.act-europe.fr (Postfix, from userid 525) id DC86E1EA5FD9; Thu, 17 Jan 2019 08:59:26 +0100 (CET) Date: Thu, 17 Jan 2019 07:59:00 -0000 From: Arnaud Charlet To: Jakub Jelinek Cc: Jeff Law , Richard Biener , Eric Botcazou , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Don't DCE const/pure calls that can throw if cfg can't be altered (PR rtl-optimization/88870) Message-ID: <20190117075926.GA30471@adacore.com> References: <20190116224311.GA30353@tucnak> <20190116225104.GC30353@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190116225104.GC30353@tucnak> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2019-01/txt/msg00986.txt.bz2 > > > PR rtl-optimization/88870 > > > * dce.c (deletable_insn_p): Never delete const/pure calls that can > > > throw if we can't alter the cfg or delete dead exceptions. > > > (mark_insn): Don't call find_call_stack_args for such calls. > > > > > > * gcc.dg/pr88870.c: New test. > > OK. Though I wonder if we want to continue to support > > -fnon-call-exceptions. With GCJ gone is there any value left in that > > capability? There's little doubt in my mind other parts of GCC are not > > -fnon-call-exception safe. > > AFAIK Ada and Go use -fnon-call-exceptions by default and heavily rely on > it. Agreed.