From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80038 invoked by alias); 17 Jan 2019 11:33:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79951 invoked by uid 89); 17 Jan 2019 11:33:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Jan 2019 11:33:20 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39ADCC070E1E; Thu, 17 Jan 2019 11:33:19 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-69.ams2.redhat.com [10.36.116.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B758A5C687; Thu, 17 Jan 2019 11:33:18 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id x0HBXGV2006045; Thu, 17 Jan 2019 12:33:16 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id x0HBXErv006044; Thu, 17 Jan 2019 12:33:14 +0100 Date: Thu, 17 Jan 2019 11:33:00 -0000 From: Jakub Jelinek To: Eric Botcazou Cc: Jeff Law , Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Don't DCE const/pure calls that can throw if cfg can't be altered (PR rtl-optimization/88870) Message-ID: <20190117113314.GG30353@tucnak> Reply-To: Jakub Jelinek References: <20190116224311.GA30353@tucnak> <20190116225104.GC30353@tucnak> <3843448.kfWJntclgd@polaris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3843448.kfWJntclgd@polaris> User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00994.txt.bz2 On Thu, Jan 17, 2019 at 12:27:31PM +0100, Eric Botcazou wrote: > > AFAIK Ada and Go use -fnon-call-exceptions by default and heavily rely on > > it. > > Right, the Ada compiler uses -fnon-call-exceptions -fdelete-dead-exceptions > and ACATS could not be passed with optimization enabled without the former. > > Btw, there are a couple of improper direct uses of flag_non_call_exceptions in > the sources, may I change them to cfun->can_throw_non_call_exceptions? Yes. > gimple-ssa-isolate-paths.c: if (!flag_non_call_exceptions) > gimple-ssa-isolate-paths.c: if (!flag_non_call_exceptions > tree-ssa-alias.c: if (flag_non_call_exceptions && pi->pt.null) Jakub