public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>, Wei Xiao <wei.william.xiao@gmail.com>
Cc: "Lu, Hongjiu" <hongjiu.lu@intel.com>,
	"H. J. Lu" <hjl.tools@gmail.com>,
	       kretz@kde.org, "Guo, Xuepeng" <xuepeng.guo@intel.com>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	       wei3.xiao@intel.com
Subject: [PATCH] Read avx512vl-vfixupimms*-2.c testcases (PR target/88489)
Date: Thu, 17 Jan 2019 13:03:00 -0000	[thread overview]
Message-ID: <20190117130315.GH30353@tucnak> (raw)
In-Reply-To: <CAHFC=N=TVKQ5q2UhNTu7cZXBaKT8NgDaaj9JG04ufHny+ZO=xw@mail.gmail.com>

On Wed, Jan 16, 2019 at 07:12:56PM +0800, Wei Xiao wrote:
> > > Yes, but please test the compiler after the revert. Please also create
> > > a runtime testcase out of the testcase in the PR.
> Yes, we have tested it but current runtime testcase can't cover the corner
> case to expose the incorrectness of SDM. We will add some after the revert.
> 
> > For r267160, I'd expect you want to revert just the config/i386/ part and
> > keep the testcases, they should work even with the changes reverted, right?
> >
> The testcase part also need to be reverted since we have changed them
> according to the incorrect intrinsic list in SDM.

I don't really understand this.

The testcases succeed just fine for me in the current trunk with all the
reversions and test something the current state of the testsuite doesn't
check normally, in particular that the testcases run correctly even when
-mavx512vl is used.  As that misbehaved in the past, we should make sure we
don't break that again.

Uros, is it ok to reapply this to current trunk?

2019-01-17  Jakub Jelinek  <jakub@redhat.com>

	Reapply:
	2018-12-15  Jakub Jelinek  <jakub@redhat.com>

	PR target/88489
	* gcc.target/i386/avx512vl-vfixupimmsd-2.c: New test.
	* gcc.target/i386/avx512vl-vfixupimmss-2.c: New test.

--- gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmsd-2.c	(nonexistent)
+++ gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmsd-2.c	(revision 268010)
@@ -0,0 +1,20 @@
+/* { dg-do run } */
+/* { dg-options "-mavx512vl -O2 -std=gnu99" } */
+/* { dg-require-effective-target avx512vl } */
+/* { dg-require-effective-target c99_runtime } */
+
+#define AVX512VL
+#define AVX512F_LEN 512
+#define AVX512F_LEN_HALF 256
+#include "avx512f-vfixupimmsd-2.c"
+
+static void
+test_256 (void)
+{
+  test_512 ();
+}
+
+static void
+test_128 (void)
+{
+}
--- gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmss-2.c	(nonexistent)
+++ gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmss-2.c	(revision 268010)
@@ -0,0 +1,20 @@
+/* { dg-do run } */
+/* { dg-options "-mavx512vl -O2 -std=gnu99" } */
+/* { dg-require-effective-target avx512vl } */
+/* { dg-require-effective-target c99_runtime } */
+
+#define AVX512VL
+#define AVX512F_LEN 512
+#define AVX512F_LEN_HALF 256
+#include "avx512f-vfixupimmss-2.c"
+
+static void
+test_256 (void)
+{
+  test_512 ();
+}
+
+static void
+test_128 (void)
+{
+}


	Jakub

  parent reply	other threads:[~2019-01-17 13:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 14:40 [PATCH] x86: Revert patches to fix PR target/88794 Wei Xiao
2019-01-15 15:14 ` Uros Bizjak
2019-01-15 15:20   ` Jakub Jelinek
2019-01-16 11:13     ` Wei Xiao
2019-01-16 14:48       ` Wei Xiao
2019-01-16 15:03         ` Jakub Jelinek
2019-01-17 13:03       ` Jakub Jelinek [this message]
2019-01-18  2:42         ` [PATCH] Read avx512vl-vfixupimms*-2.c testcases (PR target/88489) Wei Xiao
2019-01-18  7:55           ` Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117130315.GH30353@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=hongjiu.lu@intel.com \
    --cc=kretz@kde.org \
    --cc=ubizjak@gmail.com \
    --cc=wei.william.xiao@gmail.com \
    --cc=wei3.xiao@intel.com \
    --cc=xuepeng.guo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).