public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Thomas Koenig <tkoenig@netcologne.de>, Paul Thomas <pault@gcc.gnu.org>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Subject: ChangeLog formatting nits
Date: Fri, 18 Jan 2019 21:50:00 -0000	[thread overview]
Message-ID: <20190118215032.GT30353@tucnak> (raw)
In-Reply-To: <61631d6c-bf99-b4c9-227d-45a254a2d007@netcologne.de>

Hi!

On Thu, Jan 17, 2019 at 07:30:34AM +0100, Thomas Koenig wrote:
> 2019-01-17  Thomas Koenig  <tkoenig@gcc.gnu.org>
> 
> 	PR fortran/88871
> 	* resolve.c (resolve_ref):  Fix logic for removal of
> 	reference.

Just a few ChangeLog formatting nits of what I've seen recently from
multiple people, there should be exactly one space after ):, not two,
and there should be no space between ) and :, or, if there is just
filename, between filename and :, so
	* filename.whatever : New test.
is not correct and it should be
	* filename.whatever: New test.
Similarly:
	* filename.whatever : External declarations for foo and blah.
etc. should be
	* filename.whatever (foo, blah): Declare.
or similar.

Thanks.

	Jakub

      parent reply	other threads:[~2019-01-18 21:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17  6:31 [patch, fortran] Fix PR 88871 Thomas Koenig
2019-01-18 17:09 ` Thomas Koenig
2019-01-18 21:50 ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118215032.GT30353@tucnak \
    --to=jakub@redhat.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pault@gcc.gnu.org \
    --cc=tkoenig@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).