From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.vnet.ibm.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
gcc-patches@gcc.gnu.org,
Bill Schmidt <wschmidt@linux.ibm.com>
Subject: Re: [PATCH v2] rs6000: Add missing prototypes for vec_ld/vec_st
Date: Sat, 19 Jan 2019 22:23:00 -0000 [thread overview]
Message-ID: <20190119222251.GY14180@gate.crashing.org> (raw)
In-Reply-To: <15073e6c-f1dd-43cd-e470-dbdb5b780040@linux.vnet.ibm.com>
Hi Kewen,
On Sat, Jan 19, 2019 at 09:27:38PM +0800, Kewen.Lin wrote:
> Thanks for your suggestion, I just had a testing on BE machine and found the vector double related codes also need to be separated to vsx case. The case has been updated as below, is it OK for trunk?
Yes, this is fine. Thanks!
A changelog suggestion:
> 2019-01-19 Kewen Lin <linkw@gcc.gnu.org>
>
> * gcc.target/powerpc/altivec_vld_vst_addr.c: Remove.
> * gcc.target/powerpc/altivec_vld_vst_addr-1.c: New test.
> * gcc.target/powerpc/altivec_vld_vst_addr-2.c: Ditto.
Maybe you can say this like
* gcc.target/powerpc/altivec_vld_vst_addr.c: Delete, split into ...
* gcc.target/powerpc/altivec_vld_vst_addr-1.c: ... this, new test ...
* gcc.target/powerpc/altivec_vld_vst_addr-2.c: ... and this. New test.
It's fine with or without that.
Segher
prev parent reply other threads:[~2019-01-19 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 14:09 [PATCH] " Kewen.Lin
2019-01-16 17:08 ` Segher Boessenkool
2019-01-18 22:15 ` Jakub Jelinek
2019-01-19 1:05 ` Segher Boessenkool
2019-01-19 13:27 ` [PATCH v2] " Kewen.Lin
2019-01-19 22:23 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119222251.GY14180@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=linkw@linux.vnet.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).