From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82388 invoked by alias); 19 Jan 2019 22:23:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82363 invoked by uid 89); 19 Jan 2019 22:23:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 19 Jan 2019 22:23:04 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x0JMMsft015260; Sat, 19 Jan 2019 16:22:54 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x0JMMqBZ015258; Sat, 19 Jan 2019 16:22:52 -0600 Date: Sat, 19 Jan 2019 22:23:00 -0000 From: Segher Boessenkool To: "Kewen.Lin" Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org, Bill Schmidt Subject: Re: [PATCH v2] rs6000: Add missing prototypes for vec_ld/vec_st Message-ID: <20190119222251.GY14180@gate.crashing.org> References: <6ec34045-1305-cc17-15df-0cc28e5c8c77@linux.vnet.ibm.com> <20190118221512.GU30353@tucnak> <20190119010425.GX14180@gate.crashing.org> <15073e6c-f1dd-43cd-e470-dbdb5b780040@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15073e6c-f1dd-43cd-e470-dbdb5b780040@linux.vnet.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg01134.txt.bz2 Hi Kewen, On Sat, Jan 19, 2019 at 09:27:38PM +0800, Kewen.Lin wrote: > Thanks for your suggestion, I just had a testing on BE machine and found the vector double related codes also need to be separated to vsx case. The case has been updated as below, is it OK for trunk? Yes, this is fine. Thanks! A changelog suggestion: > 2019-01-19 Kewen Lin > > * gcc.target/powerpc/altivec_vld_vst_addr.c: Remove. > * gcc.target/powerpc/altivec_vld_vst_addr-1.c: New test. > * gcc.target/powerpc/altivec_vld_vst_addr-2.c: Ditto. Maybe you can say this like * gcc.target/powerpc/altivec_vld_vst_addr.c: Delete, split into ... * gcc.target/powerpc/altivec_vld_vst_addr-1.c: ... this, new test ... * gcc.target/powerpc/altivec_vld_vst_addr-2.c: ... and this. New test. It's fine with or without that. Segher