From: Segher Boessenkool <segher@kernel.crashing.org>
To: Alan Modra <amodra@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RS6000] PR88614, output_operand: invalid %z value
Date: Mon, 21 Jan 2019 14:23:00 -0000 [thread overview]
Message-ID: <20190121142257.GC14180@gate.crashing.org> (raw)
In-Reply-To: <20190121121857.GG29797@bubble.grove.modra.org>
On Mon, Jan 21, 2019 at 10:48:57PM +1030, Alan Modra wrote:
> On Mon, Jan 21, 2019 at 12:08:33AM +1030, Alan Modra wrote:
> > Hmm, if I invent a couple of new unspecs, UNSPEC_TLSGD_NOMARK and
> > UNSPEC_TLSLD_NOMARK, using them in place of UNSPEC_TLSGD and
> > UNSPEC_TLSLD when !TARGET_TLS_MARKERS then that should be enough to
> > tell when we have a -mno-tls-markers __tls_get_addr call. So I guess
> > I could kill off edit_tls_call_insn and tls_gdld_nomark. The
> > call_value_local and call_value_indirect insns would then need to
> > detect the special call and emit the arg setup insns.
>
> Here's what the revised approach looks like, but without using new
> unspecs. Bootstrap and regression test on powerpc64le-linux and
> powerpc64-linux biarch completed, and testing on powerpc64le-linux
> with -mno-tls-markers. powerpc64-linux -mno-tls-markers testing still
> in progress. OK?
This is easier to grok, thanks.
I think this would be nicer if you still used insn alternatives here.
What is needed for that?
> +void
> +rs6000_output_tlsargs (rtx *operands)
> +{
> + rtx op[3];
Maybe comment what this temporary is for?
The patch is okay for trunk (if it survives on at least all three linux
targets). Thanks!
Segher
next prev parent reply other threads:[~2019-01-21 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 22:59 Alan Modra
2019-01-18 22:02 ` Segher Boessenkool
2019-01-20 13:38 ` Alan Modra
2019-01-21 12:19 ` Alan Modra
2019-01-21 14:23 ` Segher Boessenkool [this message]
2019-01-22 0:30 ` Alan Modra
2019-01-22 0:35 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121142257.GC14180@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).