From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32367 invoked by alias); 23 Jan 2019 16:32:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32338 invoked by uid 89); 23 Jan 2019 16:32:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=talked X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Jan 2019 16:32:06 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x0NGVtJa015633; Wed, 23 Jan 2019 10:31:57 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x0NGVmd3015620; Wed, 23 Jan 2019 10:31:48 -0600 Date: Wed, 23 Jan 2019 16:34:00 -0000 From: Segher Boessenkool To: Peter Bergner Cc: GCC Patches Subject: Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc. Message-ID: <20190123163147.GG14180@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg01385.txt.bz2 Hi! On Tue, Dec 04, 2018 at 10:12:51AM -0600, Peter Bergner wrote: > We talked about replacing rs6000'c regno_or_subregno() with the generic > reg_or_subregno() function from jump.c. I agree the geberic version is > better because it has an assert that ensures we have a REG. There were > also a couple of places that could use reg_or_subregno() where we weren't. > I made those changes and tested it and ran into no regressions. > > Nearby the changes above, there were cases where could could have been using > the rtl convenience macros like REG_P, etc. to simplify the code so I did > that too...and kept going and just ended up converting all the cases I could > find that should have been using them, to use them. So the patch is large, > but pretty straight forward. In the future, please do separate patches? Especially mechanical ones could be separated (and then be much easier to review -- you also post the script, and then I don't have to check it really is mechanical, instead of just boring and you could have made mistakes). > (rs6000_init_hard_regno_mode_ok, direct_move_p): Use HARD_REGISTER_NUM_P. This line is too long. And that is the worst I see in that whole patch! Please apply it. Thanks! Segher