From: Jakub Jelinek <jakub@redhat.com>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
nd <nd@arm.com>,
James Greenhalgh <James.Greenhalgh@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection
Date: Wed, 30 Jan 2019 14:24:00 -0000 [thread overview]
Message-ID: <20190130141112.GU2135@tucnak> (raw)
In-Reply-To: <DB6PR0802MB23092D8C8F6097E4F0934183FF900@DB6PR0802MB2309.eurprd08.prod.outlook.com>
On Wed, Jan 30, 2019 at 02:06:01PM +0000, Tamar Christina wrote:
> Thanks for the feedback, but I think those are changes for another patch.
At least the memory leak is something that should be fixed even in stage4
IMNSHO.
Anyway, will defer to aarch64 maintainers here.
Just one question, for the *feat_string == '\0' case, is continue what you
want, rather than just enabled = false; and doing the
extension_flags &= ~(aarch64_extensions[i].flag);
later on?
Jakub
next prev parent reply other threads:[~2019-01-30 14:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 13:36 Tamar Christina
2019-01-10 16:57 ` Kyrill Tkachov
2019-01-23 16:28 ` Jakub Jelinek
2019-01-30 14:10 ` Tamar Christina
2019-01-30 14:24 ` Jakub Jelinek [this message]
2019-01-30 15:10 ` Tamar Christina
2019-02-07 10:43 ` Tamar Christina
2019-02-27 13:26 ` Tamar Christina
2019-02-27 18:43 ` James Greenhalgh
2019-02-27 18:44 ` Tamar Christina
2019-03-04 13:32 ` Christophe Lyon
2019-03-04 13:36 ` Tamar Christina
2019-03-04 13:38 ` Jakub Jelinek
2019-03-04 13:43 ` Tamar Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130141112.GU2135@tucnak \
--to=jakub@redhat.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).