public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Дилян Палаузов" <dilyan.palauzov@aegee.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Make clear, when contributions will be ignored
Date: Mon, 11 Feb 2019 16:27:00 -0000	[thread overview]
Message-ID: <20190211162229.GR14180@gate.crashing.org> (raw)
In-Reply-To: <5da63d0daa0f4b086f07d48a5e82240bb9a8f425.camel@aegee.org>

On Mon, Feb 11, 2019 at 02:16:27PM +0000, Дилян Палаузов wrote:
> Hello Segher,
> 
> my question was how do you propose to proceed, so that a no-reminders-for-patches-are-necessary-state is reached.
> 
> There is no relation with having infinite time or dealing with high-cost low-profit patches.
> 
> Previously I raised the quesion, whether automating the process for sending reminders, is a good idea.  This saves time
> of people to write reminders.

But that would be "optimising" exactly the wrong thing!  The choke point is
patch review.  So you should make it easier to review a patch, instead of
making it easier to send in more patches.  Your complaint is that many
patches are sent in but then not reviewed, or not reviewed for a long while,
after all.

Easy to review patches are of course first and foremost patches that do the
correct thing.  But also they need to clearly say what they fix (and how),
how the patch was tested, and they should often contain testcases for the
testsuite.  Easy to review patches usually use the same style and
presentation as all other easy to review patches.


Segher

  reply	other threads:[~2019-02-11 16:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  7:36 Make claer, " Дилян Палаузов
2018-12-05 17:13 ` Segher Boessenkool
2018-12-05 17:37   ` Joseph Myers
2018-12-07 10:55     ` Make clear, " Дилян Палаузов
2018-12-21  8:08       ` +reminder+ " Дилян Палаузов
2019-02-05 13:36       ` Дилян Палаузов
2019-02-05 23:10         ` Joseph Myers
2019-02-06 12:46       ` Segher Boessenkool
2019-02-10 14:45         ` Дилян Палаузов
2019-02-10 20:59           ` Segher Boessenkool
2019-02-11 12:44             ` Дилян Палаузов
2019-02-11 14:01               ` Segher Boessenkool
2019-02-11 14:16                 ` Дилян Палаузов
2019-02-11 16:27                   ` Segher Boessenkool [this message]
2019-02-17 17:00                     ` Дилян Палаузов
2019-02-17 19:13                       ` Segher Boessenkool
2019-02-17 19:47                         ` Дилян Палаузов
2018-12-05 17:17 ` Make claer, " Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211162229.GR14180@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dilyan.palauzov@aegee.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).