* [PATCH] rs6000: new vec-s*d-modulo.c tests should require p8vector_hw
@ 2019-02-12 2:56 Bill Schmidt
2019-02-12 14:17 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Bill Schmidt @ 2019-02-12 2:56 UTC (permalink / raw)
To: GCC Patches; +Cc: Segher Boessenkool
Hi,
It turns out that the new tests added today actually require POWER8 hardware at
a minimum, since the vec_vsrad interface requires it. (Note that requiring
P8 hardware obviates the need to specify -mvsx, so that is now removed.)
Tested on powerpc64le (P9, P8) and powerpc64 (P7) with correct behavior. Is this
okay for trunk?
Thanks,
Bill
2018-01-11 Bill Schmidt <wschmidt@linux.ibm.com>
* gcc.target/powerpc/vec-sld-modulo.c: Require p8vector_hw.
* gcc.target/powerpc/vec-srad-modulo.c: Likewise.
* gcc.target/powerpc/vec-srd-modulo.c: Likewise.
Index: gcc/testsuite/gcc.target/powerpc/vec-sld-modulo.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-sld-modulo.c (revision 268771)
+++ gcc/testsuite/gcc.target/powerpc/vec-sld-modulo.c (working copy)
@@ -1,8 +1,8 @@
/* Test that using a character splat to set up a shift-left
for a doubleword vector works correctly after gimple folding. */
-/* { dg-do run { target { vsx_hw } } } */
-/* { dg-options "-O2 -mvsx" } */
+/* { dg-do run { target { p8vector_hw } } } */
+/* { dg-options "-O2" } */
#include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-srad-modulo.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-srad-modulo.c (revision 268771)
+++ gcc/testsuite/gcc.target/powerpc/vec-srad-modulo.c (working copy)
@@ -1,8 +1,8 @@
/* Test that using a character splat to set up a shift-right algebraic
for a doubleword vector works correctly after gimple folding. */
-/* { dg-do run { target { vsx_hw } } } */
-/* { dg-options "-O2 -mvsx" } */
+/* { dg-do run { target { p8vector_hw } } } */
+/* { dg-options "-O2" } */
#include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-srd-modulo.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-srd-modulo.c (revision 268771)
+++ gcc/testsuite/gcc.target/powerpc/vec-srd-modulo.c (working copy)
@@ -1,8 +1,8 @@
/* Test that using a character splat to set up a shift-right logical
for a doubleword vector works correctly after gimple folding. */
-/* { dg-do run { target { vsx_hw } } } */
-/* { dg-options "-O2 -mvsx" } */
+/* { dg-do run { target { p8vector_hw } } } */
+/* { dg-options "-O2" } */
#include <altivec.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rs6000: new vec-s*d-modulo.c tests should require p8vector_hw
2019-02-12 2:56 [PATCH] rs6000: new vec-s*d-modulo.c tests should require p8vector_hw Bill Schmidt
@ 2019-02-12 14:17 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2019-02-12 14:17 UTC (permalink / raw)
To: Bill Schmidt; +Cc: GCC Patches
On Mon, Feb 11, 2019 at 08:56:38PM -0600, Bill Schmidt wrote:
> It turns out that the new tests added today actually require POWER8 hardware at
> a minimum, since the vec_vsrad interface requires it. (Note that requiring
> P8 hardware obviates the need to specify -mvsx, so that is now removed.)
>
> Tested on powerpc64le (P9, P8) and powerpc64 (P7) with correct behavior. Is this
> okay for trunk?
Okay if you add -mpower8-vector for these tests. Thanks,
Segher
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-12 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 2:56 [PATCH] rs6000: new vec-s*d-modulo.c tests should require p8vector_hw Bill Schmidt
2019-02-12 14:17 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).