From: Jonathan Wakely <jwakely@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>, gcc-patches@gcc.gnu.org
Subject: Re: [committed] Fix set_uids_in_ptset (PR middle-end/89303)
Date: Tue, 19 Feb 2019 02:52:00 -0000 [thread overview]
Message-ID: <20190219025254.GA13569@redhat.com> (raw)
In-Reply-To: <20190218202234.GN2135@tucnak>
On 18/02/19 21:22 +0100, Jakub Jelinek wrote:
>On Mon, Feb 18, 2019 at 09:15:39PM +0100, Rainer Orth wrote:
>> 2019-02-15 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>>
>> * g++.dg/torture/pr89303.C (bad_weak_ptr): Rename to
>> bad_weak_ptr_.
>
>Ok, thanks.
>If needed, guess we could rename much more (or rename the namespace in which
>most of it is from std to my_std, though we'd need to check for stuff that
>needs to be in std namespace).
I think that whole testcase could be in some non-std namespace. I
don't think there are any magic functions or types that need to be in
namespace std to work correctly.
>> # HG changeset patch
>> # Parent 056fe4093ce40dc462c6b50c3ae49df032a92230
>> Fix g++.dg/torture/pr89303.C with Solaris ld
>>
>> diff --git a/gcc/testsuite/g++.dg/torture/pr89303.C b/gcc/testsuite/g++.dg/torture/pr89303.C
>> --- a/gcc/testsuite/g++.dg/torture/pr89303.C
>> +++ b/gcc/testsuite/g++.dg/torture/pr89303.C
>> @@ -350,11 +350,11 @@ namespace std
>> { return static_cast<const _Tp*>(_M_addr()); }
>> };
>>
>> - class bad_weak_ptr { };
>> + class bad_weak_ptr_ { };
>>
>> inline void
>> __throw_bad_weak_ptr()
>> - { (throw (bad_weak_ptr())); }
>> + { (throw (bad_weak_ptr_())); }
>>
>> class _Sp_counted_base
>> {
>
>
> Jakub
next prev parent reply other threads:[~2019-02-19 2:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 13:34 Jakub Jelinek
2019-02-14 15:13 ` Rainer Orth
2019-02-18 20:15 ` Rainer Orth
2019-02-18 20:22 ` Jakub Jelinek
2019-02-19 2:52 ` Jonathan Wakely [this message]
2019-02-19 9:20 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219025254.GA13569@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).