public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits
Date: Sun, 24 Feb 2019 12:02:00 -0000	[thread overview]
Message-ID: <20190224004252.GV13569@redhat.com> (raw)
In-Reply-To: <7875888.L8HBVbTZ7h@polaris>

On 23/02/19 10:55 +0100, Eric Botcazou wrote:
>> I forgot to say that this is a conservative list of targets where
>> -fnon-call-exceptions is supported. Maybe it could run on other
>> targets, but this should be enough to ensure we don't get a regression
>> for this bug.
>
>What do you mean by supported exactly?

The manual for -fnon-call-exceptions says:

"Note that this requires platform-specific runtime support that does not exist everywhere."

I don't know exactly what that means, so the test only runs on targets
where I know it works.

>Ada and Go set it by default and they
>are supported on a bunch of other targets...

It's not supposed to be an exhaustive list of targets where it's
supported. As I said, it's a conservative list.

It could run on more targets, but there might not be much benefit as
long as the test runs on some targets that get tested often.


      reply	other threads:[~2019-02-24  0:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23  1:11 Jonathan Wakely
2019-02-23  1:27 ` Jakub Jelinek
2019-02-23  2:04   ` Jonathan Wakely
2019-02-23  7:17     ` Jonathan Wakely
2019-02-23  2:26 ` Jonathan Wakely
2019-02-23 14:59   ` Eric Botcazou
2019-02-24 12:02     ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190224004252.GV13569@redhat.com \
    --to=jwakely@redhat.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).