From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33443 invoked by alias); 24 Feb 2019 00:42:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33425 invoked by uid 89); 24 Feb 2019 00:42:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=exhaustive X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 24 Feb 2019 00:42:55 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F1FCFECD; Sun, 24 Feb 2019 00:42:53 +0000 (UTC) Received: from localhost (ovpn-116-14.phx2.redhat.com [10.3.116.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF6F35C28F; Sun, 24 Feb 2019 00:42:52 +0000 (UTC) Date: Sun, 24 Feb 2019 12:02:00 -0000 From: Jonathan Wakely To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits Message-ID: <20190224004252.GV13569@redhat.com> References: <20190223010220.GA32714@redhat.com> <20190223015649.GT13569@redhat.com> <7875888.L8HBVbTZ7h@polaris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <7875888.L8HBVbTZ7h@polaris> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-02/txt/msg01893.txt.bz2 On 23/02/19 10:55 +0100, Eric Botcazou wrote: >> I forgot to say that this is a conservative list of targets where >> -fnon-call-exceptions is supported. Maybe it could run on other >> targets, but this should be enough to ensure we don't get a regression >> for this bug. > >What do you mean by supported exactly? The manual for -fnon-call-exceptions says: "Note that this requires platform-specific runtime support that does not exist everywhere." I don't know exactly what that means, so the test only runs on targets where I know it works. >Ada and Go set it by default and they >are supported on a bunch of other targets... It's not supposed to be an exhaustive list of targets where it's supported. As I said, it's a conservative list. It could run on more targets, but there might not be much benefit as long as the test runs on some targets that get tested often.