From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43883 invoked by alias); 17 Apr 2019 18:53:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 43871 invoked by uid 89); 17 Apr 2019 18:53:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Apr 2019 18:53:19 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B91D381DE3; Wed, 17 Apr 2019 18:53:18 +0000 (UTC) Received: from redhat.com (unknown [10.20.4.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E99A19C58; Wed, 17 Apr 2019 18:53:17 +0000 (UTC) Date: Wed, 17 Apr 2019 19:28:00 -0000 From: Marek Polacek To: Jakub Jelinek Cc: Claudiu Zissulescu , gcc-patches@gcc.gnu.org, andrew.burgess@embecosm.com, fbedard@synopsys.com Subject: Re: [PATCH] [ARC][COMMITTED] Fix diagnostic messages. Message-ID: <20190417185316.GF4324@redhat.com> References: <20190417110933.11244-1-claziss@gmail.com> <20190417112505.GU21066@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190417112505.GU21066@tucnak> User-Agent: Mutt/1.11.3 (2019-02-01) X-SW-Source: 2019-04/txt/msg00734.txt.bz2 On Wed, Apr 17, 2019 at 01:25:05PM +0200, Jakub Jelinek wrote: > On Wed, Apr 17, 2019 at 02:09:33PM +0300, Claudiu Zissulescu wrote: > > /* Warn for unimplemented PIC in pre-ARC700 cores, and disable flag_pic. */ > > if (flag_pic && TARGET_ARC600_FAMILY) > > { > > warning (0, > > - "PIC is not supported for %s. Generating non-PIC code only..", > > + "PIC is not supported for %s. Generating non-PIC code only", > > arc_cpu_string); > > I believe this is undesirable too. Either use something like > "PIC is not supported for %s; generating non-PIC code only" > or split that into two messages > if (warning (0, "PIC is not supported for %s", arc_cpu_string)) > inform (input_location, "generating non-PIC code only"); And I suppose we should avoid pleonasm like "PIC code" ;). Marek