From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: "Dominique d'Humières" <dominiq@tournesol.lps.ens.fr>
Cc: gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/90166 -- check F2018:C1547
Date: Sat, 20 Apr 2019 17:21:00 -0000 [thread overview]
Message-ID: <20190420165734.GA3285@troutmask.apl.washington.edu> (raw)
In-Reply-To: <9E0F69D4-B2B3-4B76-B112-F493AE5ED045@lps.ens.fr>
On Sat, Apr 20, 2019 at 05:38:34PM +0200, Dominique d'Humières wrote:
>
> The changes in gfortran.dg/submodule_22.f08 look weird:
> (1) is the error in the CONTAINS of a SUBMODULE invalid?
> From
>
> * decl.c (in_module_or_interface): New function to check that the
> current state is in a module, submodule, or interface.
>
> it should not, should it?
>
> (2) left over?
> +
> +found outside of a module
>
It's a sequence of run-on errors. The first statement in
the original code is rejected with a syntax error. When
that happenrs gfc_current_state() is not COMP_MODULE,
COMP_SUBMODULE, or COMP_INTERFENCE. The next line has
the MODULE prefix, and the new check finds that it
occurs outside of MODULE, SUBMODULE, and INTERFERENCE,
so a new error occurs. The remaining errors are then
found to be bogus assignments. My conclusion, if the
first error is fixed, then the run-on errors don't
happen.
If you rather fix the problems with '! dg-options "-fmax-errors=1"'
I'm fine with that.
--
Steve
next prev parent reply other threads:[~2019-04-20 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 16:57 Dominique d'Humières
2019-04-20 17:21 ` Steve Kargl [this message]
2019-04-20 19:51 ` Steve Kargl
2019-04-20 20:30 ` Dominique d'Humières
2019-04-21 18:03 ` Steve Kargl
2019-04-22 13:53 ` Dominique d'Humières
-- strict thread matches above, loose matches on Subject: below --
2019-04-19 22:12 Steve Kargl
2019-04-20 18:37 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190420165734.GA3285@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=dominiq@tournesol.lps.ens.fr \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).