From: Jakub Jelinek <jakub@redhat.com>
To: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
Cc: Iain Buclaw <ibuclaw@gdcproject.org>,
Andreas Schwab <schwab@linux-m68k.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, libphobos] Committed added AArch64 Linux as a supported target.
Date: Thu, 25 Apr 2019 15:59:00 -0000 [thread overview]
Message-ID: <20190425154549.GA8291@tucnak> (raw)
In-Reply-To: <45b34452-670d-e955-1b71-b49e445b2a74@arm.com>
On Thu, Apr 25, 2019 at 03:32:41PM +0100, Richard Earnshaw (lists) wrote:
> > --- a/libphobos/libdruntime/core/sys/posix/sys/stat.d
> > +++ b/libphobos/libdruntime/core/sys/posix/sys/stat.d
> > @@ -709,10 +709,10 @@ version (CRuntime_Glibc)
> > }
> > int[2] __unused;
> > }
> > - static if (__USE_FILE_OFFSET64)
> > + version (D_LP64)
> > static assert(stat_t.sizeof == 128);
> > else
> > - static assert(stat_t.sizeof == 128);
> > + static assert(stat_t.sizeof == 104);
>
> I can't be sure just from the context, but 104 looks suspicious. Maybe
> that should be 64?
Why? Not all struct stat fields are pointers or longs that double for -m64
vs. -m32.
Jakub
next prev parent reply other threads:[~2019-04-25 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 23:00 Iain Buclaw
2019-04-24 7:33 ` Andreas Schwab
2019-04-24 11:25 ` Iain Buclaw
2019-04-25 14:41 ` Richard Earnshaw (lists)
2019-04-25 14:46 ` Iain Buclaw
2019-04-25 15:59 ` Jakub Jelinek [this message]
2019-04-25 16:40 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425154549.GA8291@tucnak \
--to=jakub@redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ibuclaw@gdcproject.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).