From: Jonathan Wakely <jwakely@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: Nina Dinka Ranns <dinka.ranns@gmail.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: Adding noexcept-specification on tuple constructors (LWG 2899)
Date: Mon, 29 Apr 2019 04:11:00 -0000 [thread overview]
Message-ID: <20190428214559.GK943@redhat.com> (raw)
In-Reply-To: <20190428214427.GJ943@redhat.com>
On 28/04/19 22:44 +0100, Jonathan Wakely wrote:
>On 29/04/19 00:18 +0300, Ville Voutilainen wrote:
>>On Wed, 24 Apr 2019 at 14:53, Jonathan Wakely <jwakely@redhat.com> wrote:
>>>
>>>On 24/04/19 11:21 +0100, Nina Dinka Ranns wrote:
>>>>New diff attached.
>>>
>>>Thanks, this looks great. I think we can apply this as soon as stage 1
>>>begins (which should be Real Soon Now).
>>
>>Tested on Linux-PPC64, committed to trunk. Congrats, Nina, first patch
>>in, let there be many more. :)
>
>Thanks, Nina, and Ville for taking care of the commit.
>
>Apologies for not noticing it earlier, but the first line of the
>ChangeLog entry was not formatted correctly. There should be two
>spaces either side of the author's name:
>
>2019-04-28 John Doe <jdoe@example.com>
>
>not:
>
>2019-04-28 John Doe <jdoe@example.com>
>
>I've committed r270633 to fix it.
>
>Thanks again.
Oh, and the files in the ChangeLog entry should use paths relative to
the ChangeLog file, so no libstdc++-v3/ prefixes. I missed that in the
review too.
next prev parent reply other threads:[~2019-04-28 21:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 13:28 Nina Dinka Ranns
2019-04-16 14:25 ` Jonathan Wakely
2019-04-16 15:24 ` Ville Voutilainen
2019-04-16 17:06 ` Nina Dinka Ranns
2019-04-18 20:43 ` Jonathan Wakely
2019-04-23 19:12 ` Nina Dinka Ranns
2019-04-23 21:05 ` Jonathan Wakely
2019-04-24 10:30 ` Nina Dinka Ranns
2019-04-24 12:47 ` Jonathan Wakely
2019-04-28 21:21 ` Ville Voutilainen
2019-04-28 21:44 ` Ville Voutilainen
2019-04-28 21:46 ` Jonathan Wakely
2019-04-29 4:11 ` Jonathan Wakely [this message]
2019-04-29 11:33 ` Nina Dinka Ranns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428214559.GK943@redhat.com \
--to=jwakely@redhat.com \
--cc=dinka.ranns@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).