From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61739 invoked by alias); 3 May 2019 07:18:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 61731 invoked by uid 89); 3 May 2019 07:18:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=wondering, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 May 2019 07:18:56 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD55D33025B; Fri, 3 May 2019 07:18:54 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-81.ams2.redhat.com [10.36.116.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6916A100194A; Fri, 3 May 2019 07:18:54 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id x437IqKm021810; Fri, 3 May 2019 09:18:52 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id x437IoeF021809; Fri, 3 May 2019 09:18:50 +0200 Date: Fri, 03 May 2019 07:18:00 -0000 From: Jakub Jelinek To: Richard Biener , "Joseph S. Myers" , Jeff Law Cc: gcc-patches@gcc.gnu.org, Martin =?utf-8?B?TGnFoWth?= Subject: [PATCH] Fix build with offloading (Re: [RFC][PATCH] Postpone print of --help=* option.) Message-ID: <20190503071850.GZ2706@tucnak> Reply-To: Jakub Jelinek References: <89537b9e-fac3-40eb-145a-3390d90050bf@suse.cz> <20190502103059.GQ2706@tucnak> <20190502110407.GS2706@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190502110407.GS2706@tucnak> User-Agent: Mutt/1.11.3 (2019-02-01) X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00095.txt.bz2 Hi! On Thu, May 02, 2019 at 01:04:07PM +0200, Jakub Jelinek wrote: > Well, that doesn't answer the question. > I was wondering why you couldn't: > > 2019-05-02 Jakub Jelinek > > * opts.h (finish_options): Remove lang_mask argument. > (print_help, help_option_argument): Declare. > * opts.c (print_help): Remove forward declaration, no longer static. > (finish_options): Remove lang_mask argument, don't call print_help > here. > * opts-global.c (decode_options): Adjust finish_option caller, call > print_help here. On Thu, May 02, 2019 at 01:13:22PM +0200, Martin Liška wrote: > On 5/2/19 1:04 PM, Jakub Jelinek wrote: > > Well, that doesn't answer the question. > > I was wondering why you couldn't: > > Ah sorry, you are right. The patch you suggested > is obviously nicer than what we have currently in trunk. Bootstrapped/regtested successfully now on x86_64-linux and i686-linux, ok for trunk? Jakub