From: Jonathan Wakely <jwakely@redhat.com>
To: Nina Dinka Ranns <dinka.ranns@gmail.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [v3 PATCH] Make stateful allocator propagation more consistent for operator+(basic_string) (P1165R1)
Date: Tue, 07 May 2019 11:22:00 -0000 [thread overview]
Message-ID: <20190507112247.GU2599@redhat.com> (raw)
In-Reply-To: <CAAcHv8dYSZOiGcmeEaQ9s2GyC-F1KDM+NPK2YMnA4Q7eEvJ9zA@mail.gmail.com>
On 07/05/19 12:01 +0100, Nina Dinka Ranns wrote:
>Ack. I've put the use of _Alloc_traits::is_always_equal within #if
>__cplusplus >= 201703L block since it is officially a C++17 feature.
>Let me know if you think that's an overkill.
Yes, that's overkill, we provide is_always_equal unconditionally from
C++11 onwards (to avoid ODR violations in code using different -std
options). Since it's defined fo C++11 we can use it for C++11.
I can remove that #if and test and commit the result for you though,
no need for another revision of the patch.
>New changelog below. I didn't change the description of
>operator+(basic_string&&,basic_string&&) as it's still technically
>always resulting in an allocator from the first parameter.
Yes, that looks fine. Thanks!
next prev parent reply other threads:[~2019-05-07 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 16:55 Nina Dinka Ranns
2019-05-03 22:25 ` Jonathan Wakely
2019-05-07 11:02 ` Nina Dinka Ranns
2019-05-07 11:22 ` Jonathan Wakely [this message]
2019-05-07 11:26 ` Nina Dinka Ranns
2019-05-07 11:39 ` Jonathan Wakely
2019-05-07 15:30 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507112247.GU2599@redhat.com \
--to=jwakely@redhat.com \
--cc=dinka.ranns@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).