From: Marek Polacek <polacek@redhat.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ PATCH] Using decls
Date: Tue, 21 May 2019 14:44:00 -0000 [thread overview]
Message-ID: <20190521144355.GO7979@redhat.com> (raw)
In-Reply-To: <328937e0-531e-a7be-3151-e3a622be0efa@acm.org>
Thanks for the patch and sorry for nitpicking:
On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote:
> -/* Process a local-scope or namespace-scope using declaration. SCOPE
> +/* Process a local-scope or namespace-scope using declaration.
> + FIXME
This ain't look right. You meant to document the INSERT_P param, right.
> + /* DR 36 questions why using-decls at function scope may not be
> + duplicates. Disallow it, as C++11 claimed and PR 20420
> + implemented. */
> + do_nonmember_using_decl (lookup, true, true, &value, &type);
> +
> + if (!value)
> + ;
> + else if (binding && value == binding->value)
> + ;
> + else if (binding && binding->value && TREE_CODE (value) == OVERLOAD)
> + {
> + update_local_overload (IDENTIFIER_BINDING (name), value);
> + IDENTIFIER_BINDING (name)->value = value;
> + }
> + else
> + /* Install the new binding. */
> + // FIXME: Short circuit P_L_B
Was this FIXME meant to be here?
Marek
next prev parent reply other threads:[~2019-05-21 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 14:32 Nathan Sidwell
2019-05-21 14:44 ` Marek Polacek [this message]
2019-05-21 14:47 ` Nathan Sidwell
2019-05-21 15:30 ` Nathan Sidwell
-- strict thread matches above, loose matches on Subject: below --
2017-05-23 11:07 [C++ PATCH] using decls Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521144355.GO7979@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).