From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35430 invoked by alias); 21 May 2019 14:44:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 35377 invoked by uid 89); 21 May 2019 14:44:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 May 2019 14:44:09 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2109930833C0; Tue, 21 May 2019 14:43:58 +0000 (UTC) Received: from redhat.com (unknown [10.20.4.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89BCF1017E39; Tue, 21 May 2019 14:43:57 +0000 (UTC) Date: Tue, 21 May 2019 14:44:00 -0000 From: Marek Polacek To: Nathan Sidwell Cc: GCC Patches Subject: Re: [C++ PATCH] Using decls Message-ID: <20190521144355.GO7979@redhat.com> References: <328937e0-531e-a7be-3151-e3a622be0efa@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <328937e0-531e-a7be-3151-e3a622be0efa@acm.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-SW-Source: 2019-05/txt/msg01398.txt.bz2 Thanks for the patch and sorry for nitpicking: On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote: > -/* Process a local-scope or namespace-scope using declaration. SCOPE > +/* Process a local-scope or namespace-scope using declaration. > + FIXME This ain't look right. You meant to document the INSERT_P param, right. > + /* DR 36 questions why using-decls at function scope may not be > + duplicates. Disallow it, as C++11 claimed and PR 20420 > + implemented. */ > + do_nonmember_using_decl (lookup, true, true, &value, &type); > + > + if (!value) > + ; > + else if (binding && value == binding->value) > + ; > + else if (binding && binding->value && TREE_CODE (value) == OVERLOAD) > + { > + update_local_overload (IDENTIFIER_BINDING (name), value); > + IDENTIFIER_BINDING (name)->value = value; > + } > + else > + /* Install the new binding. */ > + // FIXME: Short circuit P_L_B Was this FIXME meant to be here? Marek