From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-501837-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 76458 invoked by alias); 29 May 2019 12:33:58 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 76447 invoked by uid 89); 29 May 2019 12:33:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:985, history
X-HELO: nikam.ms.mff.cuni.cz
Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 12:33:56 +0000
Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202)	id 6FFF52804EC; Wed, 29 May 2019 14:33:53 +0200 (CEST)
Date: Wed, 29 May 2019 12:36:00 -0000
From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, d@dcepelik.cz
Subject: Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors
Message-ID: <20190529123353.kfsfisrm5mkzm6rv@kam.mff.cuni.cz>
References: <20190524111433.mv5z33ysiatlxmxz@kam.mff.cuni.cz> <alpine.LSU.2.20.1905241446340.10704@zhemvz.fhfr.qr> <20190524131856.zduvz27dbjfy6yqw@kam.mff.cuni.cz> <alpine.LSU.2.20.1905270904490.10704@zhemvz.fhfr.qr> <20190527135458.imf4ek2kd7qwefxy@kam.mff.cuni.cz> <alpine.LSU.2.20.1905291428200.10704@zhemvz.fhfr.qr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.20.1905291428200.10704@zhemvz.fhfr.qr>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SW-Source: 2019-05/txt/msg01890.txt.bz2

> On Mon, 27 May 2019, Jan Hubicka wrote:
> 
> > Hi,
> > this is minimal version of patch adding just the pointer compare.
> > Bootstrapped/regtested x86_64-linux, makes sense? :)
> 
> Yes, obviously.

Thanks, i will go ahead with installing it.
Note that I have also tested removal of:

  /* ??? Array types are not properly unified in all cases as we have
     spurious changes in the index types for example.  Removing this
     causes all sorts of problems with the Fortran frontend.  */
  if (TREE_CODE (type1) == ARRAY_TYPE
      && TREE_CODE (type2) == ARRAY_TYPE)
    return -1;

And it causes no regressions.  I looked for the history and see you
added it in 2009 because Fortran mixes up array of chars with char
itself.  I am not sure if that was fixed since then or it is just
about missing testcase?

It does not seem to be that important, but looks odd 
and makes me woried about other changes :)

Honza
> 
> Richard.