public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [PATCH] Add noexcept to tuple<> and simplify tuple<T1,T2> noexcept-specifiers
Date: Fri, 31 May 2019 15:19:00 -0000	[thread overview]
Message-ID: <20190531145802.GA602@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

	* include/std/tuple (tuple<>): Add noexcept to allocator-extended
	constructors.
	(tuple<T1, T2>::__nothrow_default_constructible()): New helper
	function.
	(tuple<T1, T2>::tuple(), explicit tuple<T1, T2>::tuple()): Use helper.

Tested powerpc64le-linux, committed to trunk.


[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 3055 bytes --]

commit d099e922a9b5ca48bed5a1fa3fc5977dbdb0f070
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri May 31 11:52:47 2019 +0100

    Add noexcept to tuple<> and simplify tuple<T1,T2> noexcept-specifiers
    
            * include/std/tuple (tuple<>): Add noexcept to allocator-extended
            constructors.
            (tuple<T1, T2>::__nothrow_default_constructible()): New helper
            function.
            (tuple<T1, T2>::tuple(), explicit tuple<T1, T2>::tuple()): Use helper.

diff --git a/libstdc++-v3/include/std/tuple b/libstdc++-v3/include/std/tuple
index b81157c097b..64516b1dece 100644
--- a/libstdc++-v3/include/std/tuple
+++ b/libstdc++-v3/include/std/tuple
@@ -898,9 +898,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
       tuple() = default;
       // No-op allocator constructors.
       template<typename _Alloc>
-	tuple(allocator_arg_t, const _Alloc&) { }
+	tuple(allocator_arg_t, const _Alloc&) noexcept { }
       template<typename _Alloc>
-	tuple(allocator_arg_t, const _Alloc&, const tuple&) { }
+	tuple(allocator_arg_t, const _Alloc&, const tuple&) noexcept { }
     };
 
   /// Partial specialization, 2-element tuple.
@@ -925,11 +925,17 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 	}
 
       template<typename _U1, typename _U2>
-    static constexpr bool __nothrow_constructible()
-    {
-      return __and_<is_nothrow_constructible<_T1, _U1>,
-			is_nothrow_constructible<_T2, _U2>>::value;
-    }
+	static constexpr bool __nothrow_constructible()
+	{
+	  return __and_<is_nothrow_constructible<_T1, _U1>,
+			    is_nothrow_constructible<_T2, _U2>>::value;
+	}
+
+      static constexpr bool __nothrow_default_constructible()
+      {
+	return __and_<is_nothrow_default_constructible<_T1>,
+		      is_nothrow_default_constructible<_T2>>::value;
+      }
 
     public:
       template <typename _U1 = _T1,
@@ -939,8 +945,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
                                      __is_implicitly_default_constructible<_U2>>
                                    ::value, bool>::type = true>
 	constexpr tuple()
-	noexcept(__and_<is_nothrow_default_constructible<_T1>,
-			is_nothrow_default_constructible<_T2>>::value)
+	noexcept(__nothrow_default_constructible())
 	: _Inherited() { }
 
       template <typename _U1 = _T1,
@@ -954,8 +959,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
                              __is_implicitly_default_constructible<_U2>>>>
                   ::value, bool>::type = false>
 	explicit constexpr tuple()
-	noexcept(__and_<is_nothrow_default_constructible<_T1>,
-			is_nothrow_default_constructible<_T2>>::value)
+	noexcept(__nothrow_default_constructible())
 	: _Inherited() { }
 
       // Shortcut for the cases where constructors taking _T1, _T2
@@ -1108,7 +1112,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
                  && _TCC<_Dummy>::template
                    _ImplicitlyConvertibleTuple<_T1, _T2>(),
                bool>::type=true>
-
 	tuple(allocator_arg_t __tag, const _Alloc& __a,
 	      const _T1& __a1, const _T2& __a2)
 	: _Inherited(__tag, __a, __a1, __a2) { }

             reply	other threads:[~2019-05-31 14:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 15:19 Jonathan Wakely [this message]
2019-06-03  9:44 ` Szabolcs Nagy
2019-06-03  9:46   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190531145802.GA602@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).