From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] rs6000: Add undocumented switch -mprefixed-addr
Date: Sun, 02 Jun 2019 23:01:00 -0000 [thread overview]
Message-ID: <20190602230138.GL31586@gate.crashing.org> (raw)
In-Reply-To: <20190530160145.GA1139@ibm-tinman.the-meissners.org>
On Thu, May 30, 2019 at 12:01:45PM -0400, Michael Meissner wrote:
> On Wed, May 29, 2019 at 03:26:27PM -0500, Bill Schmidt wrote:
> > On 5/29/19 8:16 AM, Segher Boessenkool wrote:
> > >> +/* ISA masks setting fusion options. */
> > >> +#define OTHER_FUSION_MASKS (OPTION_MASK_P8_FUSION \
> > >> + | OPTION_MASK_P8_FUSION_SIGN)
> > > Or merge the two masks into one?
> >
> > I'll ask Mike to explain this, as I don't know why there are two masks.
>
> The intention is to allow for using the numeric prefixed instructions without
> pc-relative. I.e.
[ snip ]
I was suggesting merging these two P8_FUSION{,_SIGN} into one. But, we'll
get to that some day, it doesn't have to be now.
> > >> @@ -36379,6 +36391,7 @@ static struct rs6000_opt_mask const rs6000_opt_masks[] =
> > >> { "power9-vector", OPTION_MASK_P9_VECTOR, false, true },
> > >> { "powerpc-gfxopt", OPTION_MASK_PPC_GFXOPT, false, true },
> > >> { "powerpc-gpopt", OPTION_MASK_PPC_GPOPT, false, true },
> > >> + { "prefixed-addr", OPTION_MASK_PREFIXED_ADDR, false, true },
> > > Do we want this? Why?
> >
> > Performance folks are using it for testing purposes. Eventually this
> > will probably drop out, but for now I think it's best to have the
> > undocumented switch.
>
> I use that table with -mdebug=reg so I can make sure exactly what options are
> on or off. Please add any undocumented switch to the table.
It's not very nice to have to edit everything in two completely separate
places like this.
Segher
prev parent reply other threads:[~2019-06-02 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:53 Bill Schmidt
2019-05-29 13:21 ` Segher Boessenkool
2019-05-29 21:25 ` Bill Schmidt
2019-05-29 22:00 ` Segher Boessenkool
2019-05-30 0:57 ` [PATCH v2] " Bill Schmidt
2019-05-30 15:14 ` Segher Boessenkool
2019-05-30 16:16 ` [PATCH] " Michael Meissner
2019-06-02 23:01 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190602230138.GL31586@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).