From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100807 invoked by alias); 2 Jun 2019 23:01:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 100799 invoked by uid 89); 2 Jun 2019 23:01:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=ISA, H*Ad:D*ibm.com, HX-Languages-Length:1540, powerpc-gfxopt X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 02 Jun 2019 23:01:41 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x52N1dm1012881; Sun, 2 Jun 2019 18:01:39 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x52N1cLj012879; Sun, 2 Jun 2019 18:01:38 -0500 Date: Sun, 02 Jun 2019 23:01:00 -0000 From: Segher Boessenkool To: Michael Meissner , Bill Schmidt , GCC Patches Subject: Re: [PATCH] rs6000: Add undocumented switch -mprefixed-addr Message-ID: <20190602230138.GL31586@gate.crashing.org> References: <78d1bd8d-bdaf-bb90-4e71-b8e3b9746cdf@linux.ibm.com> <20190529131629.GP31586@gate.crashing.org> <098b3e26-96ea-401e-823c-300c1935287a@linux.ibm.com> <20190530160145.GA1139@ibm-tinman.the-meissners.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190530160145.GA1139@ibm-tinman.the-meissners.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00029.txt.bz2 On Thu, May 30, 2019 at 12:01:45PM -0400, Michael Meissner wrote: > On Wed, May 29, 2019 at 03:26:27PM -0500, Bill Schmidt wrote: > > On 5/29/19 8:16 AM, Segher Boessenkool wrote: > > >> +/* ISA masks setting fusion options. */ > > >> +#define OTHER_FUSION_MASKS (OPTION_MASK_P8_FUSION \ > > >> + | OPTION_MASK_P8_FUSION_SIGN) > > > Or merge the two masks into one? > > > > I'll ask Mike to explain this, as I don't know why there are two masks. > > The intention is to allow for using the numeric prefixed instructions without > pc-relative. I.e. [ snip ] I was suggesting merging these two P8_FUSION{,_SIGN} into one. But, we'll get to that some day, it doesn't have to be now. > > >> @@ -36379,6 +36391,7 @@ static struct rs6000_opt_mask const rs6000_opt_masks[] = > > >> { "power9-vector", OPTION_MASK_P9_VECTOR, false, true }, > > >> { "powerpc-gfxopt", OPTION_MASK_PPC_GFXOPT, false, true }, > > >> { "powerpc-gpopt", OPTION_MASK_PPC_GPOPT, false, true }, > > >> + { "prefixed-addr", OPTION_MASK_PREFIXED_ADDR, false, true }, > > > Do we want this? Why? > > > > Performance folks are using it for testing purposes.  Eventually this > > will probably drop out, but for now I think it's best to have the > > undocumented switch. > > I use that table with -mdebug=reg so I can make sure exactly what options are > on or off. Please add any undocumented switch to the table. It's not very nice to have to edit everything in two completely separate places like this. Segher