public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Hashtable Small size optimization
Date: Mon, 03 Jun 2019 22:25:00 -0000	[thread overview]
Message-ID: <20190603222457.GI2599@redhat.com> (raw)
In-Reply-To: <1bf8bedd-bcc6-a181-0d0e-de4eb534b450@gmail.com>

On 03/06/19 19:18 +0200, François Dumont wrote:
>Sorry for the mis-understanding but the core of this patch has already 
>been committed after your approval here:
>
>https://gcc.gnu.org/ml/libstdc++/2019-05/msg00023.html

OK, thanks. I didn't realise it superseded this one. I thought there
might still be bits of this that would help. But looking at it again,
I see either the code touched by this patch has changed anyway, or
your patch a month ago made equivalent changes.

>It was considered as PR 90277 fix but eventually I also change tests 
>to make those implementation-details agnostics.
>
>However the performance test didn't make it, I'll re-submit it in 
>another patch more dedicated to small size optimization.

OK, that would be useful. Thanks.

It might still be useful to know more about why -O3 helps so much, but
that might require one of the middle end experts to analyze it.

Thanks!


      reply	other threads:[~2019-06-03 22:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15 22:17 François Dumont
2019-05-31 11:56 ` Jonathan Wakely
2019-06-03 17:18   ` François Dumont
2019-06-03 22:25     ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603222457.GI2599@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).