public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/4] Dump histograms only if present.
Date: Thu, 06 Jun 2019 12:53:00 -0000	[thread overview]
Message-ID: <20190606125320.t6sxdij6mqmet3iz@kam.mff.cuni.cz> (raw)
In-Reply-To: <fbe55c02-cfb4-155c-8e2b-8c694d1e7a44@suse.cz>

> On 6/6/19 2:16 PM, Jan Hubicka wrote:
> > What is the point of having histogram value when there are no counters?
> 
> Because we first create histograms in branch_prob -> gimple_find_values_to_profile and
> later we read profile from file. At that point we know which are empty, but we don't
> remove them.

OK, so it is about the dump not crahsing when you do it in meantime.
That makes sense :)
So patch is OK.

Honza

  reply	other threads:[~2019-06-06 12:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04  8:43 [PATCH 0/4] Store multiple values for single value profilers Martin Liska
2019-06-04  8:43 ` [PATCH 1/4] Remove indirect call top N counter type marxin
2019-06-06 12:52   ` Jan Hubicka
2019-06-06 13:03     ` Martin Liška
2019-06-06 13:19       ` Jan Hubicka
2019-06-04  8:43 ` [PATCH 4/4] Update a bit dump format marxin
2019-06-06 12:13   ` Jan Hubicka
2019-06-04  8:43 ` [PATCH 2/4] Implement N disk counters for single value and indirect call counters marxin
2019-06-06 12:50   ` Jan Hubicka
2019-06-07  9:11     ` Martin Liška
2019-06-07 13:58       ` Jan Hubicka
2019-06-10  7:41         ` Martin Liška
2019-06-10 18:02       ` Fix build with inhibit_libc (was Re: [PATCH 2/4] Implement N disk counters for single value and indirect call counters.) Jakub Jelinek
2019-06-10 21:53         ` Jakub Jelinek
2019-06-11  7:35           ` Martin Liška
2019-06-04  8:43 ` [PATCH 3/4] Dump histograms only if present marxin
2019-06-06 12:16   ` Jan Hubicka
2019-06-06 12:22     ` Martin Liška
2019-06-06 12:53       ` Jan Hubicka [this message]
2019-06-05 13:49 ` [PATCH 0/4] Store multiple values for single value profilers Richard Biener
2019-06-06  8:23   ` Martin Liška
2019-06-06  9:30     ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606125320.t6sxdij6mqmet3iz@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).