From: Jakub Jelinek <jakub@redhat.com>
To: Julian Brown <julian@codesourcery.com>
Cc: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
gcc-patches@gcc.gnu.org, Tom de Vries <tdevries@suse.de>,
Chung-Lin Tang <cltang@codesourcery.com>
Subject: Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory
Date: Wed, 12 Jun 2019 10:23:00 -0000 [thread overview]
Message-ID: <20190612102239.GV19695@tucnak> (raw)
In-Reply-To: <20190607150837.299df55b@squid.athome>
On Fri, Jun 07, 2019 at 03:08:37PM +0100, Julian Brown wrote:
> diff --git a/gcc/omp-low.c b/gcc/omp-low.c
> index a7f35ffe416..67e1e82ec00 100644
> --- a/gcc/omp-low.c
> +++ b/gcc/omp-low.c
> @@ -9794,6 +9882,8 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx)
>
> if (offloaded)
> {
> + mark_oacc_gangprivate (&ctx->oacc_addressable_var_decls, ctx);
> +
The above one still doesn't seem to be guarded for OpenACC constructs only.
As for the rest of the patch, you need Tom to look over the nvptx changes.
Jakub
next prev parent reply other threads:[~2019-06-12 10:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 16:21 [gomp4] add " Cesar Philippidis
2018-08-13 16:22 ` [PATCH, OpenACC] Add " Julian Brown
2018-08-13 18:42 ` Cesar Philippidis
2018-08-13 19:06 ` Cesar Philippidis
2018-08-15 16:46 ` Julian Brown
2018-08-15 19:57 ` Bernhard Reutner-Fischer
2018-08-16 15:47 ` Julian Brown
2018-08-17 16:39 ` Bernhard Reutner-Fischer
2018-12-11 15:08 ` Julian Brown
2019-06-03 16:03 ` Julian Brown
2019-06-03 16:23 ` Jakub Jelinek
2019-06-07 14:08 ` Julian Brown
2019-06-12 10:23 ` Jakub Jelinek [this message]
2019-06-12 10:32 ` Tom de Vries
2019-06-12 11:57 ` Thomas Schwinge
2019-06-12 19:43 ` Julian Brown
2019-11-06 22:59 ` Julian Brown
2021-05-21 19:05 ` Thomas Schwinge
2022-02-14 15:56 ` Thomas Schwinge
2022-02-15 13:40 ` Julian Brown
2022-03-10 11:28 ` [OpenACC privatization] Analyze 'lookup_decl'-translated DECL [PR90115, PR102330, PR104774] Thomas Schwinge
2022-03-10 11:13 ` Add 'gfortran.dg/goacc-gomp/pr102330-{1,2,3}.f90' [PR102330] Thomas Schwinge
2022-03-10 11:18 ` Add 'c-c++-common/goacc/kernels-decompose-pr104774-1.c' [PR104774] Thomas Schwinge
2018-10-05 14:07 ` [PATCH, OpenACC] Add support for gang local storage allocation in shared memory Tom de Vries
2018-08-13 20:42 ` Julian Brown
2021-05-19 12:10 ` Add 'libgomp.oacc-c-c++-common/loop-gwv-2.c' (was: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612102239.GV19695@tucnak \
--to=jakub@redhat.com \
--cc=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=julian@codesourcery.com \
--cc=rep.dot.nop@gmail.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).