public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, sanitizer] Wrap rethrow_primary_exception (PR 87880).
Date: Fri, 14 Jun 2019 14:48:00 -0000	[thread overview]
Message-ID: <20190614144754.GF19695@tucnak> (raw)
In-Reply-To: <62358CB5-F721-4DA5-BE9F-7E9A34B2A78C@sandoe.co.uk>

On Fri, Jun 14, 2019 at 03:38:05PM +0100, Iain Sandoe wrote:
> For some Darwin versions the absence of the rethrow_primary_exception
> symbol causes almost all sanitizer tests to fail.
> 
> The following patch wraps it as suggested by Jakub in the PR trail, such that
> if the gate is not defined, it’s assumed to be available.

I wonder if we shouldn't bump libasan soname because of this, as this change
is removing an exported symbol from it.

Otherwise LGTM (but bumping soname would mean it is not backportable).

> 2019-06-14  Iain Sandoe  <iain@sandoe.co.uk>
> 
> 	PR libsanitizer/87880
> 	* asan/asan_interceptors.h:
> 	(ASAN_INTERCEPT___CXA_RETHROW_PRIMARY_EXCEPTION): New.
> 	* asan/Makefile.am (DEFS): Add 
> 	ASAN_HAS_CXA_RETHROW_PRIMARY_EXCEPTION, defined to 0.
> 	* asan/Makefile.in: Regenerated.

	Jakub

  reply	other threads:[~2019-06-14 14:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 14:38 Iain Sandoe
2019-06-14 14:48 ` Jakub Jelinek [this message]
2019-06-16 18:54   ` Iain Sandoe
2019-06-16 18:58     ` Jakub Jelinek
2019-06-17  8:07       ` Jonathan Wakely
2019-06-18  8:21         ` Iain Sandoe
2019-08-19  1:11       ` Iain Sandoe
2019-08-19  1:16         ` Iain Sandoe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190614144754.GF19695@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).