From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82464 invoked by alias); 17 Jun 2019 08:07:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82455 invoked by uid 89); 17 Jun 2019 08:07:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*Ad:D*uk, HX-Greylist:Mon, H*Ad:D*co.uk, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jun 2019 08:07:28 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DEF0730872D2; Mon, 17 Jun 2019 08:07:20 +0000 (UTC) Received: from localhost (unknown [10.33.36.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90458179E8; Mon, 17 Jun 2019 08:07:20 +0000 (UTC) Date: Mon, 17 Jun 2019 08:07:00 -0000 From: Jonathan Wakely To: Jakub Jelinek Cc: Iain Sandoe , GCC Patches Subject: Re: [PATCH, sanitizer] Wrap rethrow_primary_exception (PR 87880). Message-ID: <20190617080719.GO643@redhat.com> References: <62358CB5-F721-4DA5-BE9F-7E9A34B2A78C@sandoe.co.uk> <20190614144754.GF19695@tucnak> <78C2E45E-6989-4DE2-A836-2A51C298822A@sandoe.co.uk> <20190616185842.GM19695@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190616185842.GM19695@tucnak> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.11.3 (2019-02-01) X-SW-Source: 2019-06/txt/msg00920.txt.bz2 On 16/06/19 20:58 +0200, Jakub Jelinek wrote: >On Sun, Jun 16, 2019 at 07:54:42PM +0100, Iain Sandoe wrote: >> So, I guess, unless Jonathan has plans to add __cxa_rethrow_primary_exception >> during the 10 time-frame, it’s correct to exclude the symbol anyway and we should >> bump the so version and apply trunk. > >I don't understand why they've added it, it should be called >std::rethrow_exception and that is how it is called in libstdc++. std::rethrow_exception was new in C++11, so maybe they wanted to be able to use it in C++03 code as well? (Just a guess). >> Actually, because the way in which interposing works for Darwin is different, the only >> symbol change in the library on Darwin is removing an "undefined dynamic lookup". >> So, for back-ports, I can could up with some Darwin-specific Makefike change that >> only adds the ASAN_HAS_CXA_RETHROW_PRIMARY_EXCEPTION=0 for Darwin. >> >> So - OK for trunk with a bumped soname? > >Yes. > >> (and a TODO to figure a Darwin-only backport) > >Yeah. > > Jakub