From: Arnaud Charlet <charlet@adacore.com>
To: Maciej Rozycki <macro@wdc.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"dejagnu@gnu.org" <dejagnu@gnu.org>,
Eric Botcazou <ebotcazou@libertysurf.fr>,
Pierre-Marie de Rodat <derodat@adacore.com>
Subject: Re: [PING][PATCH 0/3] GNAT test suite fixes for build sysroot
Date: Thu, 20 Jun 2019 15:14:00 -0000 [thread overview]
Message-ID: <20190620151410.GA29834@adacore.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1906191555270.11773@tpp.hgst.com>
> > Have you resolved your copyright assignment issues since then?
>
> The ball is now in FSF's court I'm told.
OK
> > The above patch needs to use "or else" instead of "or". OK with this change
> > on the above patch.
>
> OK, I have updated that in my patch.
>
> Technically both variants of the expression achieve the same effect here
> as there is no problem with evaluating both sides of the OR operation in
> all cases, but your suggestion might help the readers avoid scratching
> their heads.
The performance isn't the same, and more importantly, this is the documented
Ada coding style for GNAT: https://gcc.gnu.org/onlinedocs/gnat-style/Statements.html#Statements
Arno
next prev parent reply other threads:[~2019-06-20 15:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 21:46 [PATCH " Maciej W. Rozycki
2019-05-14 21:47 ` [PATCH 1/3][GCC] gnatmake: Accept the `--sysroot=' GCC driver option Maciej W. Rozycki
2019-05-14 21:48 ` [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation Maciej W. Rozycki
2019-05-15 23:12 ` Jacob Bachmeyer
2019-05-16 12:38 ` Maciej W. Rozycki
2019-05-16 22:57 ` Jacob Bachmeyer
2019-05-14 21:49 ` [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada Maciej W. Rozycki
2019-05-16 0:00 ` Jacob Bachmeyer
2019-05-16 12:58 ` Maciej W. Rozycki
2019-05-16 23:39 ` Jacob Bachmeyer
2019-05-21 21:37 ` Maciej Rozycki
2019-05-22 0:04 ` Jacob Bachmeyer
2019-10-25 17:40 ` [PING^3][PATCH " Maciej W. Rozycki
2019-10-26 1:30 ` Jacob Bachmeyer
2019-06-19 12:16 ` [PING][PATCH 0/3] GNAT test suite fixes for build sysroot Maciej Rozycki
2019-06-19 12:49 ` Arnaud Charlet
2019-06-20 14:51 ` Maciej Rozycki
2019-06-20 15:14 ` Arnaud Charlet [this message]
2019-06-20 15:32 ` Maciej Rozycki
2019-09-13 17:56 ` [PING^2][PATCH " Maciej W. Rozycki
2019-09-16 9:12 ` Arnaud Charlet
2019-09-23 23:21 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620151410.GA29834@adacore.com \
--to=charlet@adacore.com \
--cc=dejagnu@gnu.org \
--cc=derodat@adacore.com \
--cc=ebotcazou@libertysurf.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).