From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7246 invoked by alias); 20 Jun 2019 15:14:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7234 invoked by uid 89); 20 Jun 2019 15:14:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Jun 2019 15:14:13 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id B5FE381386; Thu, 20 Jun 2019 17:14:10 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6TBW5Ikp5dsj; Thu, 20 Jun 2019 17:14:10 +0200 (CEST) Received: from chelles.act-europe.fr (chelles.act-europe.fr [IPv6:2a02:2ab8:224:1:d6be:d9ff:fef8:4565]) by smtp.eu.adacore.com (Postfix) with ESMTP id 5966881385; Thu, 20 Jun 2019 17:14:10 +0200 (CEST) Received: by chelles.act-europe.fr (Postfix, from userid 525) id 547C81EA0079; Thu, 20 Jun 2019 17:14:10 +0200 (CEST) Date: Thu, 20 Jun 2019 15:14:00 -0000 From: Arnaud Charlet To: Maciej Rozycki Cc: "gcc-patches@gcc.gnu.org" , "dejagnu@gnu.org" , Eric Botcazou , Pierre-Marie de Rodat Subject: Re: [PING][PATCH 0/3] GNAT test suite fixes for build sysroot Message-ID: <20190620151410.GA29834@adacore.com> References: <20190619124848.GA23767@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2019-06/txt/msg01245.txt.bz2 > > Have you resolved your copyright assignment issues since then? > > The ball is now in FSF's court I'm told. OK > > The above patch needs to use "or else" instead of "or". OK with this change > > on the above patch. > > OK, I have updated that in my patch. > > Technically both variants of the expression achieve the same effect here > as there is no problem with evaluating both sides of the OR operation in > all cases, but your suggestion might help the readers avoid scratching > their heads. The performance isn't the same, and more importantly, this is the documented Ada coding style for GNAT: https://gcc.gnu.org/onlinedocs/gnat-style/Statements.html#Statements Arno