From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35389 invoked by alias); 20 Jun 2019 17:57:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 35309 invoked by uid 89); 20 Jun 2019 17:57:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=13PM, 13pm X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Jun 2019 17:57:36 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4E46730C1AD5; Thu, 20 Jun 2019 17:57:27 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 643D51001E61; Thu, 20 Jun 2019 17:57:19 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id x5KHvH6P024302; Thu, 20 Jun 2019 19:57:17 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id x5KHv86f024301; Thu, 20 Jun 2019 19:57:08 +0200 Date: Thu, 20 Jun 2019 17:57:00 -0000 From: Jakub Jelinek To: Marek Polacek Cc: Joseph Myers , Martin Sebor , GCC Patches , Jason Merrill Subject: Re: C++ PATCH for c++/60364 - noreturn after first decl not diagnosed (v2) Message-ID: <20190620175708.GT815@tucnak> Reply-To: Jakub Jelinek References: <20190615142917.GI5989@redhat.com> <20190615143326.GK19695@tucnak> <20190615143913.GJ5989@redhat.com> <20190616161037.GK5989@redhat.com> <20190617181053.GR5989@redhat.com> <20190620164913.GH5989@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190620164913.GH5989@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg01259.txt.bz2 On Thu, Jun 20, 2019 at 12:49:13PM -0400, Marek Polacek wrote: > Sorry about that. Does this patch work? > > 2019-06-20 Marek Polacek > > * config/sh/sh.c (sh2a_function_vector_p): Use get_attribute_name. Just that? grep is_attribute_p.*TREE_PURPOSE config/*/* config/m32c/m32c.c: if (is_attribute_p ("interrupt", TREE_PURPOSE (list))) config/m32c/m32c.c: if (is_attribute_p ("bank_switch", TREE_PURPOSE (list))) config/m32c/m32c.c: if (is_attribute_p ("fast_interrupt", TREE_PURPOSE (list))) config/m32c/m32c.c: if (is_attribute_p ("function_vector", TREE_PURPOSE (list))) config/m32c/m32c.c: if (is_attribute_p ("function_vector", TREE_PURPOSE (list))) config/rl78/rl78.c: if (is_attribute_p ("saddr", TREE_PURPOSE (list))) config/sh/sh.c: if (is_attribute_p ("sp_switch", TREE_PURPOSE (attrs)) config/sh/sh.c: || is_attribute_p ("trap_exit", TREE_PURPOSE (attrs)) config/sh/sh.c: || is_attribute_p ("nosave_low_regs", TREE_PURPOSE (attrs)) config/sh/sh.c: || is_attribute_p ("resbank", TREE_PURPOSE (attrs))) config/sh/sh.c: if (is_attribute_p ("function_vector", TREE_PURPOSE (list))) config/sh/sh.c: if (is_attribute_p ("function_vector", TREE_PURPOSE (list))) > diff --git gcc/config/sh/sh.c gcc/config/sh/sh.c > index 07d5b3c1df5..dfaeab55142 100644 > --- gcc/config/sh/sh.c > +++ gcc/config/sh/sh.c > @@ -8646,7 +8646,7 @@ sh2a_function_vector_p (tree func) > return false; > > for (tree list = SH_ATTRIBUTES (func); list; list = TREE_CHAIN (list)) > - if (is_attribute_p ("function_vector", TREE_PURPOSE (list))) > + if (is_attribute_p ("function_vector", get_attribute_name (list))) > return true; > > return false; Jakub