From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15579 invoked by alias); 27 Jun 2019 18:41:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15565 invoked by uid 89); 27 Jun 2019 18:41:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=H*i:sk:CB71AC7, H*f:sk:CB71AC7 X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jun 2019 18:41:15 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 19EB1282520; Thu, 27 Jun 2019 20:41:13 +0200 (CEST) Date: Thu, 27 Jun 2019 18:41:00 -0000 From: Jan Hubicka To: Iain Sandoe Cc: Jason Merrill , Martin =?iso-8859-2?Q?Li=B9ka?= , Jonathan Wakely , Richard Biener , Jakub Jelinek , "gcc@gcc.gnu.org" , David Edelsohn , GCC Patches Subject: Re: [PATCH] Deprecate -frepo option. Message-ID: <20190627184113.bieoglmjbgboydhr@kam.mff.cuni.cz> References: <20190621115838.GX815@tucnak> <79fcb5a4-0eba-d39f-e7ca-389f371cd48c@suse.cz> <20190621141309.GY815@tucnak> <8f69bb0f-096a-94ee-8606-9f3564ae114e@suse.cz> <20190627182132.iicu2mli5zdixh4s@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2019-06/txt/msg01805.txt.bz2 > > > On 27 Jun 2019, at 19:21, Jan Hubicka wrote: > > > >> > >> It's useful on targets without COMDAT support. Are there any such > >> that we care about at this point? > >> > >> If the problem is the combination with LTO, why not just prohibit that? > > > > The problem is that at the collect2 time we want to decide whether to > > hold stderr/stdout of the linker. The issue is that we do not know yet > > if we are going to LTO (because that is decided by linker plugin) or > > whether we do repo files (because we look for those only after linker > > failure). > > you could pre-scan for LTO, as is done for the collect2+non-plugin linker. > (similar to the comment below, that would take some time, but probably > small c.f the actual link). the collect2+non-plugin does not handle static archives so it would need more work while I think we should kill that code (and make darwin to use lld) Honza > Iain > > > We can look for repo files first but that could take some time > > especially for large programs (probably not too bad compared to actual > > linking later) or we may require -frepo to be passed to collect2. > > > > Honza > >> > >> Jason >