public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: acsawdey@linux.ibm.com
Cc: gcc-patches@gcc.gnu.org, segher@kernel.crashing.org,
	wschmidt@linux.ibm.com, dje.gcc@gmail.com, gnu@amylaar.uk
Subject: Re: [PATCH 04/30] Changes to arc
Date: Mon, 01 Jul 2019 11:30:00 -0000	[thread overview]
Message-ID: <20190701113015.GS23204@embecosm.com> (raw)
In-Reply-To: <f77c3c5af663484daba20ceaf0efabd8611ab02d.1561408899.git.acsawdey@linux.ibm.com>

* acsawdey@linux.ibm.com <acsawdey@linux.ibm.com> [2019-06-25 15:22:13 -0500]:

> From: Aaron Sawdey <acsawdey@linux.ibm.com>
> 
> 	* config/arc/arc-protos.h: Change movmem to cpymem.
> 	* config/arc/arc.c (arc_expand_movmem): Change movmem to cpymem.
> 	* config/arc/arc.h: Change movmem to cpymem in comment.
> 	* config/arc/arc.md (movmemsi): Change movmem to cpymem.

OK for ARC.

Thanks,
Andrew

> ---
>  gcc/config/arc/arc-protos.h | 2 +-
>  gcc/config/arc/arc.c        | 6 +++---
>  gcc/config/arc/arc.h        | 2 +-
>  gcc/config/arc/arc.md       | 4 ++--
>  4 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/gcc/config/arc/arc-protos.h b/gcc/config/arc/arc-protos.h
> index f501bc3..74e5247 100644
> --- a/gcc/config/arc/arc-protos.h
> +++ b/gcc/config/arc/arc-protos.h
> @@ -35,7 +35,7 @@ extern void arc_final_prescan_insn (rtx_insn *, rtx *, int);
>  extern const char *arc_output_libcall (const char *);
>  extern int arc_output_addsi (rtx *operands, bool, bool);
>  extern int arc_output_commutative_cond_exec (rtx *operands, bool);
> -extern bool arc_expand_movmem (rtx *operands);
> +extern bool arc_expand_cpymem (rtx *operands);
>  extern bool prepare_move_operands (rtx *operands, machine_mode mode);
>  extern void emit_shift (enum rtx_code, rtx, rtx, rtx);
>  extern void arc_expand_atomic_op (enum rtx_code, rtx, rtx, rtx, rtx, rtx);
> diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c
> index 89f69c79..23171d2 100644
> --- a/gcc/config/arc/arc.c
> +++ b/gcc/config/arc/arc.c
> @@ -8883,7 +8883,7 @@ arc_output_commutative_cond_exec (rtx *operands, bool output_p)
>    return 8;
>  }
>  
> -/* Helper function of arc_expand_movmem.  ADDR points to a chunk of memory.
> +/* Helper function of arc_expand_cpymem.  ADDR points to a chunk of memory.
>     Emit code and return an potentially modified address such that offsets
>     up to SIZE are can be added to yield a legitimate address.
>     if REUSE is set, ADDR is a register that may be modified.  */
> @@ -8917,7 +8917,7 @@ force_offsettable (rtx addr, HOST_WIDE_INT size, bool reuse)
>     offset ranges.  Return true on success.  */
>  
>  bool
> -arc_expand_movmem (rtx *operands)
> +arc_expand_cpymem (rtx *operands)
>  {
>    rtx dst = operands[0];
>    rtx src = operands[1];
> @@ -10427,7 +10427,7 @@ arc_use_by_pieces_infrastructure_p (unsigned HOST_WIDE_INT size,
>  				    enum by_pieces_operation op,
>  				    bool speed_p)
>  {
> -  /* Let the movmem expander handle small block moves.  */
> +  /* Let the cpymem expander handle small block moves.  */
>    if (op == MOVE_BY_PIECES)
>      return false;
>  
> diff --git a/gcc/config/arc/arc.h b/gcc/config/arc/arc.h
> index 80dead9..4a9dd07 100644
> --- a/gcc/config/arc/arc.h
> +++ b/gcc/config/arc/arc.h
> @@ -1423,7 +1423,7 @@ do { \
>     in one reasonably fast instruction.  */
>  #define MOVE_MAX 4
>  
> -/* Undo the effects of the movmem pattern presence on STORE_BY_PIECES_P .  */
> +/* Undo the effects of the cpymem pattern presence on STORE_BY_PIECES_P .  */
>  #define MOVE_RATIO(SPEED) ((SPEED) ? 15 : 3)
>  
>  /* Define this to be nonzero if shift instructions ignore all but the
> diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md
> index 528e344..ba595dd 100644
> --- a/gcc/config/arc/arc.md
> +++ b/gcc/config/arc/arc.md
> @@ -5122,13 +5122,13 @@ core_3, archs4x, archs4xd, archs4xd_slow"
>     (set_attr "type" "loop_end")
>     (set_attr "length" "4,20")])
>  
> -(define_expand "movmemsi"
> +(define_expand "cpymemsi"
>    [(match_operand:BLK 0 "" "")
>     (match_operand:BLK 1 "" "")
>     (match_operand:SI 2 "nonmemory_operand" "")
>     (match_operand 3 "immediate_operand" "")]
>    ""
> -  "if (arc_expand_movmem (operands)) DONE; else FAIL;")
> +  "if (arc_expand_cpymem (operands)) DONE; else FAIL;")
>  
>  ;; Close http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35803 if this works
>  ;; to the point that we can generate cmove instructions.
> -- 
> 2.7.4
> 

  reply	other threads:[~2019-07-01 11:30 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 20:23 [PATCH 00/30] Rename movmem pattern to cpymem acsawdey
2019-06-25 20:24 ` [PATCH 04/30] Changes to arc acsawdey
2019-07-01 11:30   ` Andrew Burgess [this message]
2019-06-25 20:24 ` [PATCH 03/30] Changes for alpha acsawdey
2019-06-25 20:24 ` [PATCH 02/30] Changes for aarch64 acsawdey
2019-06-26  8:59   ` Richard Earnshaw (lists)
2019-06-25 20:25 ` [PATCH 05/30] Changes to arm acsawdey
2019-06-26  8:59   ` Richard Earnshaw
2019-06-25 20:25 ` [PATCH 07/30] Changes to bfin acsawdey
2019-06-25 20:25 ` [PATCH 06/30] Changes to avr acsawdey
2019-06-25 20:26 ` [PATCH 10/30] Changes to ft32 acsawdey
2019-06-25 20:26 ` [PATCH 11/30] Changes to h8300 acsawdey
2019-06-25 20:26 ` [PATCH 08/30] Changes to c6x acsawdey
2019-06-25 20:26 ` [PATCH 09/30] Changes to frv acsawdey
2019-06-25 20:27 ` [PATCH 12/30] Changes to i386 acsawdey
2019-06-26  7:57   ` Uros Bizjak
2019-06-25 20:28 ` [PATCH 14/30] Changes to m32c acsawdey
2019-06-25 20:28 ` [PATCH 01/30] Changes to machine independent code acsawdey
2019-06-25 21:43   ` Jeff Law
2019-06-26  8:37     ` Richard Sandiford
2019-06-26  8:58       ` Richard Earnshaw
2019-06-26 20:16     ` [PATCH 31/30] Update documentation for movmem to cpymem change Aaron Sawdey
2019-06-26 22:06       ` Jeff Law
2019-06-27 18:39     ` [PATCH 32/30] Document movmem/cpymem changes in gcc-10/changes.html Aaron Sawdey
2019-06-28 21:33       ` Jeff Law
2019-06-25 20:28 ` [PATCH 13/30] Changes to lm32 acsawdey
2019-06-25 20:29 ` [PATCH 16/30] Changes to mcore acsawdey
2019-06-25 20:29 ` [PATCH 15/30] Changes to m32r acsawdey
2019-06-25 20:30 ` [PATCH 17/30] Changes to microblaze acsawdey
2019-06-25 20:49   ` Michael Eager
2019-06-25 20:30 ` [PATCH 18/30] Changes to mips acsawdey
2019-06-25 20:31 ` [PATCH 19/30] Changes to nds32 acsawdey
2019-06-25 20:31 ` [PATCH 20/30] Changes to pa acsawdey
2019-06-25 20:32 ` [PATCH 21/30] Changes to pdp11 acsawdey
2019-06-27 14:19   ` Paul Koning
2019-06-25 20:37 ` [PATCH 22/30] Changes to riscv acsawdey
2019-06-25 20:38 ` [PATCH 24/30] Changes to rx acsawdey
2019-06-25 20:38 ` [PATCH 23/30] Changes to rs6000 acsawdey
2019-06-26 21:57   ` Segher Boessenkool
2019-06-25 20:39 ` [PATCH 26/30] Changes to sh acsawdey
2019-06-29  0:50   ` Oleg Endo
2019-06-25 20:39 ` [PATCH 25/30] Changes to s390 acsawdey
2019-06-25 20:40 ` [PATCH 29/30] Changes to visium acsawdey
2019-06-25 20:40 ` [PATCH 27/30] Changes to sparc acsawdey
2019-06-25 20:40 ` [PATCH 28/30] Changes to vax acsawdey
2019-06-25 20:41 ` [PATCH 30/30] Changes to xtensa acsawdey
2019-06-25 20:41   ` augustine.sterling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190701113015.GS23204@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=acsawdey@linux.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu@amylaar.uk \
    --cc=segher@kernel.crashing.org \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).