From: Jan Hubicka <hubicka@ucw.cz>
To: "Martin Liška" <mliska@suse.cz>
Cc: Xiong Hu Luo <luoxhu@linux.ibm.com>,
gcc-patches@gcc.gnu.org, segher@kernel.crashing.org,
wschmidt@linux.ibm.com, luoxhu@cn.ibm.com
Subject: Re: [PATCH 2/2] Rename SINGE_VALUE to TOPN_VALUES counters.
Date: Wed, 03 Jul 2019 09:09:00 -0000 [thread overview]
Message-ID: <20190703090930.hxovaaesio4cowxa@kam.mff.cuni.cz> (raw)
In-Reply-To: <92ed1dc9-0ecf-a794-a907-9f5bf9f8017f@suse.cz>
> And the second part is rename so that it reflect reality
> that single value can actually track multiple values.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin
> From cc9e93d43941176e92b5821e5a8134a5319a10b4 Mon Sep 17 00:00:00 2001
> From: Martin Liska <mliska@suse.cz>
> Date: Thu, 20 Jun 2019 14:50:23 +0200
> Subject: [PATCH 2/2] Rename SINGE_VALUE to TOPN_VALUES counters.
>
> gcc/ChangeLog:
>
> 2019-06-20 Martin Liska <mliska@suse.cz>
>
> * gcov-counter.def (GCOV_COUNTER_V_SINGLE): Remove.
> (GCOV_COUNTER_V_TOPN): New.
> (GCOV_COUNTER_V_INDIR): Use _topn.
> * gcov-io.h (GCOV_DISK_SINGLE_VALUES): Remove.
> (GCOV_TOPN_VALUES): New.
> (GCOV_SINGLE_VALUE_COUNTERS): Remove.
> (GCOV_TOPN_VALUES_COUNTERS): New.
> * profile.c (instrument_values): Use HIST_TYPE_TOPN_VALUES.
> * tree-profile.c:
> (gimple_init_gcov_profiler): Rename variables from one_value
> to topn_values.
> (gimple_gen_one_value_profiler): Remove.
> (gimple_gen_topn_values_profiler): New function.
> * value-prof.c (dump_histogram_value): Use TOPN_VALUES
> names instead of SINGLE_VALUE.
> (stream_out_histogram_value): Likewise.
> (stream_in_histogram_value): Likewise.
> (get_most_common_single_value): Likewise.
> (gimple_divmod_fixed_value_transform): Likewise.
> (gimple_stringops_transform): Likewise.
> (gimple_divmod_values_to_profile): Likewise.
> (gimple_stringops_values_to_profile): Likewise.
> (gimple_find_values_to_profile): Likewise.
> * value-prof.h (enum hist_type): Rename to TOPN.
> (gimple_gen_one_value_profiler): Remove.
> (gimple_gen_topn_values_profiler): New.
>
> libgcc/ChangeLog:
>
> 2019-06-20 Martin Liska <mliska@suse.cz>
>
> * Makefile.in: Use topn_values instead of one_value names.
> * libgcov-merge.c (__gcov_merge_single): Move to ...
> (__gcov_merge_topn): ... this.
> (merge_single_value_set): Move to ...
> (merge_topn_values_set): ... this.
> * libgcov-profiler.c (__gcov_one_value_profiler_body): Move to
> ...
> (__gcov_topn_values_profiler_body): ... this.
> (__gcov_one_value_profiler_v2): Move to ...
> (__gcov_topn_values_profiler): ... this.
> (__gcov_one_value_profiler_v2_atomic): Move to ...
> (__gcov_topn_values_profiler_atomic): ... this.
> (__gcov_indirect_call_profiler_v4): Remove.
> * libgcov-util.c (__gcov_single_counter_op): Move to ...
> (__gcov_topn_counter_op): ... this.
> * libgcov.h (L_gcov_merge_single): Remove.
> (L_gcov_merge_topn): New.
> (__gcov_merge_single): Remove.
> (__gcov_merge_topn): New.
> (__gcov_one_value_profiler_v2): Move to ..
> (__gcov_topn_values_profiler): ... this.
> (__gcov_one_value_profiler_v2_atomic): Move to ...
> (__gcov_topn_values_profiler_atomic): ... this.
OK,
I would rename the __gcov_topn_values_profiler to _v2 since we had this
function before.
Honza
next prev parent reply other threads:[~2019-07-03 9:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 1:46 [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization Xiong Hu Luo
2019-06-18 5:51 ` Martin Liška
2019-06-18 9:03 ` luoxhu
2019-06-18 9:34 ` Martin Liška
2019-06-18 10:07 ` Segher Boessenkool
2019-06-18 10:20 ` Martin Liška
2019-06-19 5:38 ` luoxhu
2019-06-19 6:57 ` Martin Liška
2019-06-18 10:21 ` Martin Liška
2019-06-19 8:50 ` luoxhu
2019-06-19 8:56 ` Martin Liška
2019-06-19 12:18 ` Martin Liška
2019-06-20 1:59 ` luoxhu
2019-06-20 6:15 ` luoxhu
2019-06-20 12:57 ` Martin Liška
2019-06-20 13:47 ` Jan Hubicka
2019-06-20 14:45 ` Martin Liška
2019-07-01 11:20 ` Martin Liška
2019-07-03 9:08 ` Jan Hubicka
2019-06-20 14:46 ` [PATCH 2/2] Rename SINGE_VALUE to TOPN_VALUES counters Martin Liška
2019-07-01 11:21 ` Martin Liška
2019-07-03 9:09 ` Jan Hubicka [this message]
2019-07-03 12:41 ` Martin Liška
2019-06-24 2:34 ` [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization luoxhu
2019-06-24 9:20 ` luoxhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703090930.hxovaaesio4cowxa@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=luoxhu@cn.ibm.com \
--cc=luoxhu@linux.ibm.com \
--cc=mliska@suse.cz \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).