From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79846 invoked by alias); 4 Jul 2019 06:50:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79799 invoked by uid 89); 4 Jul 2019 06:50:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jul 2019 06:50:48 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id BB01681392; Thu, 4 Jul 2019 08:50:45 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EvLRt-J0nKZZ; Thu, 4 Jul 2019 08:50:45 +0200 (CEST) Received: from chelles.act-europe.fr (chelles.act-europe.fr [IPv6:2a02:2ab8:224:1:d6be:d9ff:fef8:4565]) by smtp.eu.adacore.com (Postfix) with ESMTP id A4EBA8138E; Thu, 4 Jul 2019 08:50:45 +0200 (CEST) Received: by chelles.act-europe.fr (Postfix, from userid 525) id 9B7EF1EA1714; Thu, 4 Jul 2019 08:50:45 +0200 (CEST) Date: Thu, 04 Jul 2019 07:01:00 -0000 From: Arnaud Charlet To: James Clarke Cc: gcc-patches@gcc.gnu.org, James Clarke Subject: Re: [PATCH] [Ada] Make clockid_t type public on GNU/kFreeBSD Message-ID: <20190704065045.GA18833@adacore.com> References: <20190703223514.65803-1-jrtc27@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703223514.65803-1-jrtc27@debian.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2019-07/txt/msg00330.txt.bz2 OK, thanks. > From: James Clarke > > Monotonic_Clock and RT_Resolution in the recently-added s-tpopmo.adb > call clock_gettime/clock_getres with the integral constants from OSC and > thus rely on clockid_t being an integral type, so we cannot hide it on > GNU/kFreeBSD. Instead, make the definition public to match all the other > implementations. > > gcc/ada > * libgnarl/s-osinte__kfreebsd-gnu.ads (clockid_t): Make type > definition public. > (CLOCK_REALTIME): Make value public. > --- > gcc/ada/libgnarl/s-osinte__kfreebsd-gnu.ads | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/gcc/ada/libgnarl/s-osinte__kfreebsd-gnu.ads b/gcc/ada/libgnarl/s-osinte__kfreebsd-gnu.ads > index 408187314..b60ffd2c0 100644 > --- a/gcc/ada/libgnarl/s-osinte__kfreebsd-gnu.ads > +++ b/gcc/ada/libgnarl/s-osinte__kfreebsd-gnu.ads > @@ -206,9 +206,8 @@ package System.OS_Interface is > function nanosleep (rqtp, rmtp : access timespec) return int; > pragma Import (C, nanosleep, "nanosleep"); > > - type clockid_t is private; > - > - CLOCK_REALTIME : constant clockid_t; > + type clockid_t is new int; > + CLOCK_REALTIME : constant clockid_t := 0; > > function clock_gettime > (clock_id : clockid_t; > @@ -607,9 +606,6 @@ private > end record; > pragma Convention (C, timespec); > > - type clockid_t is new int; > - CLOCK_REALTIME : constant clockid_t := 0; > - > type pthread_attr_t is record > detachstate : int; > schedpolicy : int; > -- > 2.17.1 >