From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129193 invoked by alias); 8 Jul 2019 08:19:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128626 invoked by uid 89); 8 Jul 2019 08:19:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_NEUTRAL autolearn=ham version=3.3.1 spammy=UD:interface9.adb, exp_disp.adb, exp_dispadb, implements X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jul 2019 08:19:06 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkOrY-0002TW-2P for gcc-patches@gcc.gnu.org; Mon, 08 Jul 2019 04:19:05 -0400 Received: from rock.gnat.com ([205.232.38.15]:40314) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkOrX-0002MG-Ts for gcc-patches@gcc.gnu.org; Mon, 08 Jul 2019 04:19:04 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D7CF65617F; Mon, 8 Jul 2019 04:18:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2yej1eu0JbDQ; Mon, 8 Jul 2019 04:18:59 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id E74CE56182; Mon, 8 Jul 2019 04:18:57 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4862) id E31A8602; Mon, 8 Jul 2019 04:18:57 -0400 (EDT) Date: Mon, 08 Jul 2019 08:19:00 -0000 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Javier Miranda Subject: [Ada] Crash in interface derivation with null primitive Message-ID: <20190708081857.GA80620@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8t9RHnE3ZwKMSgU+" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 205.232.38.15 X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00544.txt.bz2 --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 695 The frontend crashes processing the derivation of a tagged type whose ultimate ancestor is an interface type I1 that has a null primitive, implements another interface I2 derived from I2, and does not override the null primitive. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-08 Javier Miranda gcc/ada/ * exp_disp.adb (Register_Primitive): When registering a primitive in the secondary dispatch table, handle primitive inherited through several levels of type derivation (required to properly handle inherited 'null' primitive). gcc/testsuite/ * gnat.dg/interface9.adb, gnat.dg/interface9_root-child.ads, gnat.dg/interface9_root.ads: New testcase. --8t9RHnE3ZwKMSgU+ Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="patch.diff" Content-length: 1580 --- gcc/ada/exp_disp.adb +++ gcc/ada/exp_disp.adb @@ -7637,7 +7637,7 @@ package body Exp_Disp is Unchecked_Convert_To (RTE (RE_Prim_Ptr), Make_Attribute_Reference (Loc, Prefix => - New_Occurrence_Of (Alias (Prim), Loc), + New_Occurrence_Of (Ultimate_Alias (Prim), Loc), Attribute_Name => Name_Unrestricted_Access)))); end if; --- /dev/null new file mode 100644 +++ gcc/testsuite/gnat.dg/interface9.adb @@ -0,0 +1,10 @@ +-- { dg-do compile } + +with Interface9_Root.Child; +procedure Interface9 is + package R is new Interface9_Root (Real => Float); + package RC is new R.Child; + +begin + null; +end Interface9; --- /dev/null new file mode 100644 +++ gcc/testsuite/gnat.dg/interface9_root-child.ads @@ -0,0 +1,7 @@ +generic +package Interface9_Root.Child is + type Base_Type is abstract new Base_Interface with null record; + + type Derived_Type is abstract new Base_Type and Derived_Interface + with null record; -- Test +end Interface9_Root.Child; --- /dev/null new file mode 100644 +++ gcc/testsuite/gnat.dg/interface9_root.ads @@ -0,0 +1,10 @@ +generic + type Real is digits <>; +package Interface9_Root is + type Base_Interface is limited interface; + + procedure Primitive1 (B : in out Base_Interface) is abstract; + procedure Primitive2 (B : in out Base_Interface) is null; + + type Derived_Interface is limited interface and Base_Interface; +end Interface9_Root; --8t9RHnE3ZwKMSgU+--