From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-504627-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 79316 invoked by alias); 8 Jul 2019 16:32:49 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 79227 invoked by uid 89); 8 Jul 2019 16:32:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=
X-HELO: gate.crashing.org
Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jul 2019 16:32:47 +0000
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])	by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x68GWjJI019444;	Mon, 8 Jul 2019 11:32:45 -0500
Received: (from segher@localhost)	by gate.crashing.org (8.14.1/8.14.1/Submit) id x68GWi0b019443;	Mon, 8 Jul 2019 11:32:44 -0500
Date: Mon, 08 Jul 2019 16:56:00 -0000
From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: Richard Biener <rguenther@suse.de>, GCC Patches <gcc-patches@gcc.gnu.org>,        Bill Schmidt <wschmidt@linux.ibm.com>
Subject: Re: [PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref
Message-ID: <20190708163244.GE30355@gate.crashing.org>
References: <c58cd9cc-9768-f4a0-eedd-78d742d4f808@linux.ibm.com> <alpine.LSU.2.20.1907021407420.2976@zhemvz.fhfr.qr> <8d92a6c9-e338-e662-9eec-ef3059faba71@linux.ibm.com> <alpine.LSU.2.20.1907031406490.2976@zhemvz.fhfr.qr> <23b4209c-2c15-a9c3-1322-023f75a67e0c@linux.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <23b4209c-2c15-a9c3-1322-023f75a67e0c@linux.ibm.com>
User-Agent: Mutt/1.4.2.3i
X-IsSubscribed: yes
X-SW-Source: 2019-07/txt/msg00595.txt.bz2

Hi Kewen,

On Mon, Jul 08, 2019 at 04:07:00PM +0800, Kewen.Lin wrote:
> gcc/ChangeLog

(You have trailing spaces in the changelog, fwiw).

> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88497-1.c
> @@ -0,0 +1,60 @@
> +/* { dg-do run } */
> +/* { dg-require-effective-target vect_double } */
> +/* { dg-require-effective-target powerpc_vsx_ok { target { powerpc*-*-* } } } */

For "dg-do run" tests, you need "powerpc_vsx_hw".  "_ok" only tests if
the assembler can handle VSX instructions, not whether the test system
can run them.  (powerpc_vsx_ok is what you need for "dg-do assemble" or
"dg-do link" tests.  It also tests if you can use -mvsx, but that doesn't
do what you might hope it does: you can use -mvsx together with a -mcpu=
that doesn't support VSX, for example).

> +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88497-2.c
> @@ -0,0 +1,37 @@
> +/* { dg-do compile } */
> +/* { dg-require-effective-target vect_float } */
> +/* { dg-require-effective-target powerpc_altivec_ok { target { powerpc*-*-* } } } */

This one is fine, and the rest of the tests as well.


Segher