From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82693 invoked by alias); 12 Jul 2019 15:46:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82677 invoked by uid 89); 12 Jul 2019 15:46:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1185 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Jul 2019 15:46:31 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA346307D864; Fri, 12 Jul 2019 15:46:30 +0000 (UTC) Received: from localhost (unknown [10.33.36.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CE9B100164A; Fri, 12 Jul 2019 15:46:30 +0000 (UTC) Date: Fri, 12 Jul 2019 15:56:00 -0000 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Define std::atomic_ref and std::atomic for C++20 Message-ID: <20190712154629.GP4665@redhat.com> References: <20190711194500.GA27493@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="JkW1gnuWHDypiMFO" Content-Disposition: inline In-Reply-To: <20190711194500.GA27493@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.11.3 (2019-02-01) X-SW-Source: 2019-07/txt/msg00986.txt.bz2 --JkW1gnuWHDypiMFO Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-length: 255 On 11/07/19 20:45 +0100, Jonathan Wakely wrote: >+ // Repeat for volatile std::atomic >+ if constexpr (std::atomic::is_always_lock_free) Thanks to Uros for pointing out this typo. Fixed by the attached patch, committed to trunk. --JkW1gnuWHDypiMFO Content-Type: text/x-patch; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" Content-length: 904 commit 991bdaf97870e2775a15314823759aec7fd79599 Author: redi Date: Fri Jul 12 15:45:16 2019 +0000 Fix inaccurate comment in new test * testsuite/29_atomics/atomic_float/1.cc: Fix comment. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@273448 138bc75d-0d04-0410-961f-82ee72b054a4 diff --git a/libstdc++-v3/testsuite/29_atomics/atomic_float/1.cc b/libstdc++-v3/testsuite/29_atomics/atomic_float/1.cc index bd0e353538d..b56c026fb99 100644 --- a/libstdc++-v3/testsuite/29_atomics/atomic_float/1.cc +++ b/libstdc++-v3/testsuite/29_atomics/atomic_float/1.cc @@ -476,7 +476,7 @@ test03() VERIFY( a0 == 13.2l ); } - // Repeat for volatile std::atomic + // Repeat for volatile std::atomic if constexpr (std::atomic::is_always_lock_free) { volatile std::atomic a0; --JkW1gnuWHDypiMFO--