From: Marek Polacek <polacek@redhat.com>
To: Matthew Beliveau <mbelivea@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] PR c++/90590 Suppress warning for enumeration value not handled in switch warning
Date: Fri, 12 Jul 2019 18:41:00 -0000 [thread overview]
Message-ID: <20190712183859.GQ5989@redhat.com> (raw)
In-Reply-To: <CAOrE4X1_tX7Rtj2SvF1C7iym6zmr6J58bBzTNxuP-X+r8bbF9g@mail.gmail.com>
On Fri, Jul 12, 2019 at 02:34:37PM -0400, Matthew Beliveau wrote:
> @@ -1628,6 +1629,16 @@ c_do_switch_warnings (splay_tree cases, location_t switch_location,
> if (cond && tree_int_cst_compare (cond, value))
> continue;
>
> + /* If the enumerator is defined in a system header and uses a reserved
> + name, then we continue to avoid throwing a warning. */
> + location_t loc = DECL_SOURCE_LOCATION
> + (TYPE_STUB_DECL (TYPE_MAIN_VARIANT (type)));
As I mentioned before, I wonder if we can get away without the
TYPE_MAIN_VARIANT here.
> + if (in_system_header_at (loc)
> + && name_reserved_for_implementation_p
> + (IDENTIFIER_POINTER (TREE_PURPOSE (chain))))
> + continue;
> +
> +
Please drop one newline here.
Marek
next prev parent reply other threads:[~2019-07-12 18:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 15:53 Matthew Beliveau
2019-07-09 17:48 ` Marek Polacek
2019-07-09 21:23 ` Jason Merrill
2019-07-12 18:39 ` Matthew Beliveau
2019-07-12 18:41 ` Marek Polacek [this message]
2019-07-12 23:00 ` Marek Polacek
2019-07-15 14:17 ` Matthew Beliveau
2019-07-16 12:42 ` Marek Polacek
2019-07-23 15:33 ` Matthew Beliveau
2019-07-30 19:46 ` Matthew Beliveau
2019-07-31 18:58 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712183859.GQ5989@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=mbelivea@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).