public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Richard Biener <rguenther@suse.de>,
	gcc-patches@gcc.gnu.org,	d@dcepelik.cz
Subject: Re: Make nonoverlapping_component_refs work with duplicated main variants
Date: Tue, 16 Jul 2019 09:30:00 -0000	[thread overview]
Message-ID: <20190716093011.cvs55cozvayx5jr3@kam.mff.cuni.cz> (raw)
In-Reply-To: <yddbly1kmg9.fsf@CeBiTec.Uni-Bielefeld.DE>

> Hi Jan,
> 
> > 	* g++.dg/lto/alias-3_0.C: New file.
> > 	* g++.dg/lto/alias-3_1.c: New file.
> 
> the new test has a couple of problems: DejaGnu warns everywhere:
> 
> WARNING: lto.exp does not support dg-lto-do in secondary source files
> WARNING: lto.exp does not support dg-lto-options in secondary source files
> 
> This would have been prominent in either mail-report.log or the runtest
> output.
> 
> Besides, the test FAILs in the same way as its companions lto/alias-[12]
> on Solaris (PRs ipa/90720 and lto/91028).  Your fix for the latter two
> didn't change anything, btw., neither on Solaris nor on Linux/x86_64
> with -fno-use-linker-plugin.
Hi,
sorry for the noise.  This patch fixes -fno-use-linker-plugin for me and
also removes the extra dg-do I forgot in alias_3-1.c

	* alias-1_0.C: Use -O3.
	* alias-2_0.C: Use -O3.
	* alias-3_0.C: Add loop to enable inlining with -fno-use-linker-plugin.
	* alias-3_1.C: Remove dg-lto-do and dg-lto-options.
Index: g++.dg/lto/alias-1_0.C
===================================================================
--- g++.dg/lto/alias-1_0.C	(revision 273478)
+++ g++.dg/lto/alias-1_0.C	(working copy)
@@ -1,5 +1,5 @@
 /* { dg-lto-do run } */
-/* { dg-lto-options { { -O2 -flto } } } */
+/* { dg-lto-options { { -O3 -flto } } } */
 
 /* With LTO we consider all pointers to incomplete types to be possibly
    aliasing.  This makes *bptr to alias with aptr.
Index: g++.dg/lto/alias-2_0.C
===================================================================
--- g++.dg/lto/alias-2_0.C	(revision 273478)
+++ g++.dg/lto/alias-2_0.C	(working copy)
@@ -1,5 +1,5 @@
 /* { dg-lto-do run } */
-/* { dg-lto-options { { -O2 -flto } } } */
+/* { dg-lto-options { { -O3 -flto } } } */
 
 /* With LTO we consider all pointers to incomplete types to be possibly
    aliasing.  This makes *bptr to alias with aptr.
Index: g++.dg/lto/alias-3_0.C
===================================================================
--- g++.dg/lto/alias-3_0.C	(revision 273478)
+++ g++.dg/lto/alias-3_0.C	(working copy)
@@ -14,13 +14,15 @@ __attribute__ ((used)) struct b b, *bptr
 __attribute__ ((used)) int i,j;
 
 extern "C" void inline_me_late (void);
+int n=1;
 
 int
 main (void)
 {
   int jj=j;
   bptr2->a[jj].bar = 0;
-  inline_me_late ();
+  for (int i=0; i<n; i++)
+    inline_me_late ();
   if (!__builtin_constant_p (bptr2->a[jj].bar == 0))
     __builtin_abort ();
   return 0;
Index: g++.dg/lto/alias-3_1.c
===================================================================
--- g++.dg/lto/alias-3_1.c	(revision 273478)
+++ g++.dg/lto/alias-3_1.c	(working copy)
@@ -1,5 +1,3 @@
-/* { dg-lto-do run } */
-/* { dg-lto-options { { -O3 -flto -fno-early-inlining } } } */
 struct a
 {
   int foo,bar;

  reply	other threads:[~2019-07-16  9:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08  7:39 Jan Hubicka
2019-07-08  9:10 ` Richard Biener
2019-07-08 10:48   ` Jan Hubicka
2019-07-09 12:02   ` Jan Hubicka
2019-07-09 12:21     ` Richard Biener
2019-07-09 12:41       ` Jan Hubicka
2019-07-09 12:52         ` Richard Biener
2019-07-09 13:10           ` Jan Hubicka
2019-07-09 13:30             ` Richard Biener
2019-07-09 13:37       ` Jan Hubicka
2019-07-09 13:41         ` Richard Biener
2019-07-09 21:03           ` Bernhard Reutner-Fischer
2019-07-11  8:29     ` Rainer Orth
2019-07-16  9:30       ` Jan Hubicka [this message]
2019-07-16 11:58         ` Rainer Orth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190716093011.cvs55cozvayx5jr3@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=d@dcepelik.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).