From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38658 invoked by alias); 22 Jul 2019 21:36:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38566 invoked by uid 89); 22 Jul 2019 21:36:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=Configurations, configurations X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jul 2019 21:36:39 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x6MLaaRX011889; Mon, 22 Jul 2019 16:36:37 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x6MLaXGS011888; Mon, 22 Jul 2019 16:36:33 -0500 Date: Mon, 22 Jul 2019 21:43:00 -0000 From: Segher Boessenkool To: Paul Clarke Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v2] [rs6000] Add documentation for __builtin_mtfsf Message-ID: <20190722213633.GI20882@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg01452.txt.bz2 On Mon, Jul 22, 2019 at 09:00:08AM -0500, Paul Clarke wrote: > > 2019-07-21 Paul A. Clarke > > [gcc] > > * doc/extend.texi: Add documentation for __builtin_mtfsf. It should mention the section this is in... That is "Basic PowerPC Built-in Functions Available on all Configurations" I think? > v2: wordsmithing at Segher's request. I'm having a hard time not saying too much. :-) :-) > -accessing the sticky status bits. The > +accessing the sticky status bits. The @code{__builtin_mtfsf} takes a constant > +8-bit integer field mask and a representation of the new value of the FPSCR > +and generates the @code{mtfsf} (extended mnemonic) instruction to write new > +values to selected fields of the FPSCR. The "The @code{__builtin_mtfsf} takes a constant 8-bit integer field mask and a double precision floating point argument, and generates" etc.? (It's not a representation of the new value, it says nothing about the fields you do *not* write). Okay for trunk with such a change. All backports are fine as well. Thanks! Segher