From: Jakub Jelinek <jakub@redhat.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: Richard Biener <rguenther@suse.de>,
Mike Stump <mikestump@comcast.net>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Tamar Christina <Tamar.Christina@arm.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix up gcc.dg/type-convert-var.c testcase (was Re: [GCC][middle-end] Add rules to strip away unneeded type casts in expressions (2nd patch))
Date: Tue, 30 Jul 2019 07:13:00 -0000 [thread overview]
Message-ID: <20190730071124.GI15878@tucnak> (raw)
In-Reply-To: <ydd36ioq9xc.fsf@CeBiTec.Uni-Bielefeld.DE>
On Tue, Jul 30, 2019 at 09:05:35AM +0200, Rainer Orth wrote:
> > This new testcase FAILs e.g. on i686-linux. The problem is that
>
> this is PR middle-end/91282.
Indeed.
> > with no dg-options, the testcase options default to -ansi, which
> > implies -fexcess-precision=standard. On i686-linux, that is conversion to
> > long double which must (and does) survive until expansion.
> >
> > Fixed by using -fexcess-precision=fast, tested on x86_64-linux and
> > i686-linux, ok for trunk?
> >
> > 2019-07-30 Jakub Jelinek <jakub@redhat.com>
> >
> > * gcc.dg/type-convert-var.c: Add -0fexcess-precision=fast to
> ^ typo
Oops, fixed:
2019-07-30 Jakub Jelinek <jakub@redhat.com>
PR middle-end/91282
* gcc.dg/type-convert-var.c: Add -fexcess-precision=fast to
dg-additional-options.
--- gcc/testsuite/gcc.dg/type-convert-var.c.jj 2019-07-28 17:29:27.156351325 +0200
+++ gcc/testsuite/gcc.dg/type-convert-var.c 2019-07-30 08:51:33.349558035 +0200
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-additional-options "-O1 -fdump-tree-optimized" } */
+/* { dg-additional-options "-fexcess-precision=fast -O1 -fdump-tree-optimized" } */
void foo (float a, float b, float *c)
{
double e = (double)a * (double)b;
Jakub
next prev parent reply other threads:[~2019-07-30 7:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 8:31 [GCC][middle-end] Add rules to strip away unneeded type casts in expressions (2nd patch) Tamar Christina
2019-06-25 8:33 ` Tamar Christina
2019-06-25 9:02 ` Richard Biener
2019-07-02 9:41 ` Tamar Christina
2019-07-02 10:20 ` Richard Biener
2019-07-02 16:44 ` Tamar Christina
2019-07-03 9:06 ` Richard Biener
2019-07-30 7:05 ` [PATCH] Fix up gcc.dg/type-convert-var.c testcase (was Re: [GCC][middle-end] Add rules to strip away unneeded type casts in expressions (2nd patch)) Jakub Jelinek
2019-07-30 7:09 ` Rainer Orth
2019-07-30 7:13 ` Jakub Jelinek [this message]
2019-07-30 7:34 ` Richard Biener
2019-07-30 7:11 ` Fix up -fexcess-precision handling in LTO " Jakub Jelinek
2019-07-30 7:42 ` Richard Biener
2019-07-30 7:46 ` Jakub Jelinek
2019-08-06 15:02 ` Patch ping (Re: Fix up -fexcess-precision handling in LTO (was Re: [GCC][middle-end] Add rules to strip away unneeded type casts in expressions (2nd patch))) Jakub Jelinek
2019-08-19 22:27 ` Fix up -fexcess-precision handling in LTO (was Re: [GCC][middle-end] Add rules to strip away unneeded type casts in expressions (2nd patch)) Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730071124.GI15878@tucnak \
--to=jakub@redhat.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=mikestump@comcast.net \
--cc=rguenther@suse.de \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).